|
|
| Participants: |
David Mudrak and Eric Merrill
|
| Security Level: |
None
|
| QA Assignee: |
David Mudrak
|
| Resolved date: |
07/May/09
|
| Affected Branches: |
MOODLE_19_STABLE
|
| Fixed Branches: |
MOODLE_16_STABLE, MOODLE_17_STABLE, MOODLE_18_STABLE, MOODLE_19_STABLE
|
When a user (student) goes to view a workshop with a password, there are a number of errors on the page that is displayed.
The form isn't closed, incorrect js is used (not compatable with all browsers), if will not function with js turned off, and the page footer is not printed.
The attached diff should address all those problems.
I know workshop is getting a major overhall for 2.0, but it would be nice if this fix could make it in for 1.9.5 - I can commit it if there isn't any objection.
Thanks
|
|
Description
|
When a user (student) goes to view a workshop with a password, there are a number of errors on the page that is displayed.
The form isn't closed, incorrect js is used (not compatable with all browsers), if will not function with js turned off, and the page footer is not printed.
The attached diff should address all those problems.
I know workshop is getting a major overhall for 2.0, but it would be nice if this fix could make it in for 1.9.5 - I can commit it if there isn't any objection.
Thanks |
Show » |
|
Bug
Closed
Minor
Workshop password login page incomplete/broken
thanks for the patch. Is JavaScript event onClick needed for the <input> type "submit"? Does it have any special meaning here? I would leave it without JavScript.
Feel free to commit and assign me as QA.
TIA