[#MDL-19092] Workshop password login page incomplete/broken - Moodle Tracker

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 1.9.4
Fix Version/s: 1.6.9+, 1.7.7+, 1.8.9, 1.9.5
Component/s: Workshop
Labels:
None

Affected Branches:
MOODLE_19_STABLE
Fixed Branches:
MOODLE_16_STABLE, MOODLE_17_STABLE, MOODLE_18_STABLE, MOODLE_19_STABLE

Description

When a user (student) goes to view a workshop with a password, there are a number of errors on the page that is displayed.

The form isn't closed, incorrect js is used (not compatable with all browsers), if will not function with js turned off, and the page footer is not printed.

The attached diff should address all those problems.

I know workshop is getting a major overhall for 2.0, but it would be nice if this fix could make it in for 1.9.5 - I can commit it if there isn't any objection.

Thanks

More Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

workshop.diff

07/May/09 5:28 AM

0.7 kB

Eric Merrill

Issue Links

This issue is duplicated by:
MDL-17077	Password submision in Workshop module

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

David Mudrak added a comment - 07/May/09 3:02 PM

Eric,

thanks for the patch. Is JavaScript event onClick needed for the <input> type "submit"? Does it have any special meaning here? I would leave it without JavScript.

Feel free to commit and assign me as QA.

TIA

Show

David Mudrak added a comment - 07/May/09 3:02 PM Eric, thanks for the patch. Is JavaScript event onClick needed for the <input> type "submit"? Does it have any special meaning here? I would leave it without JavScript. Feel free to commit and assign me as QA. TIA

Hide

Permalink

Eric Merrill added a comment - 07/May/09 8:42 PM

Just got rid of the js, since I agree with David that it appears to have no purpose.

Committed changes to 19, 18, 17, and 16.

Show

Eric Merrill added a comment - 07/May/09 8:42 PM Just got rid of the js, since I agree with David that it appears to have no purpose. Committed changes to 19, 18, 17, and 16.

Hide

Permalink

David Mudrak added a comment - 12/May/09 4:26 PM

Reviewed. Closing. Thanks Eric!

Show

David Mudrak added a comment - 12/May/09 4:26 PM Reviewed. Closing. Thanks Eric!

People

Assignee:

Eric Merrill

Reporter:

Eric Merrill

Tester:

David Mudrak

Participants:

David Mudrak, Eric Merrill

Vote (0)

Watch (1)

Dates

Created:

07/May/09 5:28 AM

Updated:

12/May/09 4:47 PM

Resolved:

07/May/09 8:45 PM