Moodle

choosecoursefile form element doesn't allow attributes to be specified for text field

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.9.4
  • Fix Version/s: 1.9.5
  • Component/s: Forms Library
  • Labels:
    None
  • Difficulty:
    Moderate
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

It seems that the "choosecoursefile" formslib group element doesn't allow to specify any attribute in the $attributes parameter. They are set to the group element without effect in the text field. So things like size or maxlength cannot be specified.

As the group only has 2 elements (buttton and text), make it to forward any attribute received straight to the text element.

Issue Links

Activity

Hide
Eloy Lafuente (stronk7) added a comment -

Done, now attributes are passed to text field and old 48 size default is respected, unless defined. Resolving as fixed.

Show
Eloy Lafuente (stronk7) added a comment - Done, now attributes are passed to text field and old 48 size default is respected, unless defined. Resolving as fixed.
Hide
Sam Hemelryk added a comment -

All looks, and works well, thanks Eloy

Show
Sam Hemelryk added a comment - All looks, and works well, thanks Eloy

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: