Moodle

In Internet Explorer 6 with AJAX activated for courses and course edit mode on, the usual drop-down menus to add resources or activities do not appear.

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.9.5
  • Fix Version/s: 1.9.6
  • Component/s: AJAX
  • Labels:
    None
  • Environment:
    Internet Explorer 6

Description

To reproduce the bug:

1. Activate AJAX on course level
2. Enter a course and turn editing on
3. Observe that the drop-down menus do not appear. Only the help buttons are visible.

Only Internet Explorer 6 seems to be affected. IE7 and 8 are behaving as expected.

Moodle Version: MOODLE_19_WEEKLY, Build 20090506. The MOODLE_19_WEEKLY before that version probably didn't have that bug.

Issue Links

This issue duplicates:
MDL-16940 including a YUI CSS file breaks ajax editing in IE6 Minor Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Ralf Seliger added a comment -

1.9.5 is affected as well.

Show
Ralf Seliger added a comment - 1.9.5 is affected as well.
Hide
Permalink
Geoffrey Rowland added a comment -

This seems to be the same as, or at least related to, http://tracker.moodle.org/browse/MDL-16940 (can't seem to Link to this issue)

This has a suggested fix (below), though this does not seem to work for us with Moodle 1.9.5. I have added it in case it helps towards a full solution.

-------------------------------------------------------------------------------------------------------------

the file \lib\yui\container\assets\skins\sam\container.css

contains the following CSS selector, which makes all the select boxes on the page disappear. Might be a YUI bug, but I had to comment it to make things work. (no line number as the file is minified)

.masked select,.drag select,.hide-select select{_visibility:hidden;}

Show
Geoffrey Rowland added a comment - This seems to be the same as, or at least related to, http://tracker.moodle.org/browse/MDL-16940 (can't seem to Link to this issue) This has a suggested fix (below), though this does not seem to work for us with Moodle 1.9.5. I have added it in case it helps towards a full solution. ------------------------------------------------------------------------------------------------------------- the file \lib\yui\container\assets\skins\sam\container.css contains the following CSS selector, which makes all the select boxes on the page disappear. Might be a YUI bug, but I had to comment it to make things work. (no line number as the file is minified) .masked select,.drag select,.hide-select select{_visibility:hidden;}
Hide
Permalink
Geoffrey Rowland added a comment -

I can now confirm the above fix, from MDL-16940, does work for Moodle 1.9.5 (YUI 2.6.0).

Note that the 'offending' YUI CSS code

.masked select,.drag select,.hide-select select{_visibility:hidden;}

occurs in more than one file, but should be commented out from:

\lib\yui\container\assets\skins\sam\container.css

Show
Geoffrey Rowland added a comment - I can now confirm the above fix, from MDL-16940, does work for Moodle 1.9.5 (YUI 2.6.0). Note that the 'offending' YUI CSS code .masked select,.drag select,.hide-select select{_visibility:hidden;} occurs in more than one file, but should be commented out from: \lib\yui\container\assets\skins\sam\container.css
Hide
Permalink
Ralf Seliger added a comment -

@Goeffrey:

yes, your fix works for me, too, and so far I don't see any side effects. I guess that will do until the issue is fixed in 1.9.6.

Thanks a lot.

Show
Ralf Seliger added a comment - @Goeffrey: yes, your fix works for me, too, and so far I don't see any side effects. I guess that will do until the issue is fixed in 1.9.6. Thanks a lot.
Hide
Permalink
Ralf Seliger added a comment -

Sorry for the typo in your name, Geoffrey

Show
Ralf Seliger added a comment - Sorry for the typo in your name, Geoffrey
Hide
Permalink
Geoffrey Rowland added a comment -

No worries...

...and the credit for this fix belongs to Matt Gibson who reported it in MDL-16940

Show
Geoffrey Rowland added a comment - No worries... ...and the credit for this fix belongs to Matt Gibson who reported it in MDL-16940
Hide
Permalink
Kris Besley added a comment -

Fix works as suggested. I had to make an amendment to both \lib\yui\assets\skins\sam\skin.css and lib\yui\assets\skins\sam\container.css too.

Show
Kris Besley added a comment - Fix works as suggested. I had to make an amendment to both \lib\yui\assets\skins\sam\skin.css and lib\yui\assets\skins\sam\container.css too.
Hide
Permalink
Jens Eremie added a comment -

Thanks for the fix, works with IE6 and m195+,
Jens

Show
Jens Eremie added a comment - Thanks for the fix, works with IE6 and m195+, Jens
Hide
Permalink
Dan Poltawski added a comment -

Reassigning to Dongsheng since Nicolas is a busy moving at the moment.

Dongsheng, hope you don't mind

Show
Dan Poltawski added a comment - Reassigning to Dongsheng since Nicolas is a busy moving at the moment. Dongsheng, hope you don't mind
Hide
Permalink
Martin Dougiamas added a comment -

Nicolas can you check this and get it in if all is good?

Show
Martin Dougiamas added a comment - Nicolas can you check this and get it in if all is good?
Hide
Permalink
Jonathan Harker added a comment -

We fixed this in IE6 on the latest 1.9.5 by only adding the .drag select to theme/standard/styles_ie6.css (see MDL-16940) - the YUI css was not touched.

Show
Jonathan Harker added a comment - We fixed this in IE6 on the latest 1.9.5 by only adding the .drag select to theme/standard/styles_ie6.css (see MDL-16940) - the YUI css was not touched.
Hide
Permalink
Nicolas Connault added a comment -

Resolved, thanks for the fix!

Show
Nicolas Connault added a comment - Resolved, thanks for the fix!
Hide
Permalink
Rossiani Wijaya added a comment -

Please refer to tracker no. 16940 for css patch. Thank you.

Resolved

Closing

Show
Rossiani Wijaya added a comment - Please refer to tracker no. 16940 for css patch. Thank you. Resolved Closing

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.