Moodle

Disable "Aggregate only non-empty grades" for SUM aggregation

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 1.9.4
  • Fix Version/s: STABLE backlog
  • Component/s: Gradebook
  • Labels:
  • Affected Branches:
    MOODLE_19_STABLE

Description

Sorry, I cannot test it on http://test.moodle.org/1.9, but I have just tried the latest code that we have and "Aggregate only non-empty grades" does not seem to work for SUM.
(non-empty grades are still considered for the aggregation).

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Elena Ivanova added a comment -

emm.. I mean to say that EMPTY grades are still included, if I check the checkbox

Show
Elena Ivanova added a comment - emm.. I mean to say that EMPTY grades are still included, if I check the checkbox
Hide
Permalink
Petr Škoda (skodak) added a comment -

I do not understand, including empty value in a sum returns the same number of points.

I suppose we should disable this setting if sum agg selected, right?

Show
Petr Škoda (skodak) added a comment - I do not understand, including empty value in a sum returns the same number of points. I suppose we should disable this setting if sum agg selected, right?
Hide
Permalink
Elena Ivanova added a comment -

yes sorry for my math skills..
If functionality is not there, we better hide it.

Show
Elena Ivanova added a comment - yes sorry for my math skills.. If functionality is not there, we better hide it.
Hide
Permalink
Petr Škoda (skodak) added a comment -

changing the title a bit and working on solution, thanks

Show
Petr Škoda (skodak) added a comment - changing the title a bit and working on solution, thanks
Hide
Permalink
Petr Škoda (skodak) added a comment -

I have reviewed the code, the category edit form is ok, we should imho add the disabling of agg non-empty checkbox on categories page too, assigning to Nicolas (author of the new categories UI)

Show
Petr Škoda (skodak) added a comment - I have reviewed the code, the category edit form is ok, we should imho add the disabling of agg non-empty checkbox on categories page too, assigning to Nicolas (author of the new categories UI)
Hide
Permalink
Murad Jamal added a comment -

yes .. this checkbox must be disabled on SUM aggregation !! it's so confusing ...

Show
Murad Jamal added a comment - yes .. this checkbox must be disabled on SUM aggregation !! it's so confusing ...
Hide
Permalink
Helen Foster added a comment -

Can anyone confirm whether this remains an issue in 2.0? Assigning to our gradebook expert, Andrew.

Show
Helen Foster added a comment - Can anyone confirm whether this remains an issue in 2.0? Assigning to our gradebook expert, Andrew.
Hide
Permalink
Tamara Snyder added a comment -

Yes this is still a problem in 2.0. When you say "disable this setting if summ agg selected", hopefully that means that by default empty grades will not be included in the sum of grades?

Show
Tamara Snyder added a comment - Yes this is still a problem in 2.0. When you say "disable this setting if summ agg selected", hopefully that means that by default empty grades will not be included in the sum of grades?
Hide
Permalink
Tamara Snyder added a comment -

Please see attached screenshot - although sum of grade points is same whether or not non-graded assignments are included, the course total Letter Grade and Percent which student sees are incorrect. Non-graded assignments should be excluded from sum of grades by default, or at least a "Progressive Sum of Grades" should be offered as an option.

Show
Tamara Snyder added a comment - Please see attached screenshot - although sum of grade points is same whether or not non-graded assignments are included, the course total Letter Grade and Percent which student sees are incorrect. Non-graded assignments should be excluded from sum of grades by default, or at least a "Progressive Sum of Grades" should be offered as an option.

People

Vote (11)
Watch (5)

Dates

  • Created:
    Updated:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.