[#MDL-19211] Text editors cleanup and improvements META

Issue Details (XML | Word | Printable)

Key:	MDL-19211
Type:	Task
Status:	Open
Priority:	Major
Assignee:	Petr Skoda
Reporter:	Petr Skoda
Votes:	0
Watchers:	2

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

Text editors cleanup and improvements META

Created: 17/May/09 01:34 AM Updated: 19/Jun/09 09:21 PM

Return to search

Component/s:

HTML Editor

Affects Version/s:

2.0

Fix Version/s:

2.0

Issue Links:

Relates

This issue has a non-specific relationship to:

MDL-19521 Dragmath 2.0 meta

Participants:	Marc Grober, Mauno Korpelainen and Petr Skoda
Security Level:	None
Affected Branches:	MOODLE_20_STABLE
Fixed Branches:	MOODLE_20_STABLE

Sub-Tasks:

All

Open

Sub-Task Progress:

1.	implement new text editor preferences in user profile	Open	Petr Skoda
2.	reimplement global text editor settings	Open	Petr Skoda
3.	evaluate inclusion of asciimath plugin	Open	Petr Skoda
4.	reimplement multilang support	Open	Petr Skoda
5.	Restore buttons that were lost in the tinymce upgrade	Open	Petr Skoda
6.	implement spell checker	Open	Nobody

Description

« Hide

* upgrade tinymce
* make editors pluggable again
* improve lang strings handling
* upgrade DragMath
* etc.

All

Comments

Change History

Version Control

Sort Order:

Petr Skoda committed 11 files to 'Moodle CVS' - 18/May/09 05:10 AM

MDL-19211 text editor plugins configuration

MODIFY	lib/adminlib.php	Rev. 1.357	(+135 -3 lines)
MODIFY	lib/Attic/javascript.php	Rev. 1.49	(+7 -6 lines)
MODIFY	admin/uploaduser_form.php	Rev. 1.13	(+3 -1 lines)
MODIFY	lang/en_utf8/editor.php	Rev. 1.5	(+7 -1 lines)
MODIFY	version.php	Rev. 1.1112	(+1 -1 lines)
MODIFY	lib/editorlib.php	Rev. 1.9	(+1 -6 lines)
MODIFY	admin/settings/plugins.php	Rev. 1.41	(+9 -1 lines)
MODIFY	lib/db/upgrade.php	Rev. 1.299	(+17 -3 lines)
MODIFY	lib/db/install.php	Rev. 1.11	(+2 -1 lines)
MODIFY	lang/en_utf8/editor_tinymce.php	Rev. 1.5	(+1 -1 lines)
ADD	admin/editors.php	Rev. 1.1	(+0 -0 lines)

Mitsuhiro Yoshida committed 4 files to 'Lang CVS' - 18/May/09 08:58 AM

MDL-19211 Translated new strings for text editor plugins configuration.

ADD	ja_utf8/editor_textarea.php	Rev. 1.1	(+0 -0 lines)
MODIFY	ja_utf8/editor.php	Rev. 1.20	(+5 -1 lines)
MODIFY	ja_utf8/editor_tinymce.php	Rev. 1.5	(+54 -53 lines)
MODIFY	ja_utf8/README	Rev. 1.998	(+1 -1 lines)

Petr Skoda committed 2 files to 'Moodle CVS' - 18/May/09 04:17 PM

MDL-19211 spellchecker TODOs

MODIFY	lib/editor/tinymce/readme_moodle.txt		Rev. 1.6		(+2 -2 lines)
MODIFY	lib/editor/tinymce/extra/Attic/tinymce.js.php		Rev. 1.4		(+6 -4 lines)

Petr Skoda committed 1 file to 'Moodle CVS' - 19/May/09 09:02 PM

MDL-19211 more inline docs and comments

MODIFY

lib/editorlib.php

Rev. 1.10

(+56 -10 lines)

martignoni committed 2 files to 'Lang CVS' - 28/May/09 01:05 AM

MDL-19211 New strings added

MODIFY	fr_utf8/editor_tinymce.php		Rev. 1.5		(+2 -1 lines)
MODIFY	fr_utf8/editor.php		Rev. 1.8		(+5 -1 lines)

[ Permalink | « Hide ]

Marc Grober added a comment - 16/Jun/09 10:52 AM

As the person nominally identified as the Moodle maintainer for DragMath, might I inquire as to:

how changing what is in Moodle HEAD to 0.7.7, which was out of date when the changes were made, constitutes "upgrading"
why DragMath has now been placed, contrary to the prior discussion, not in /lib/editor/common nor in /lib/common, but in /lib/dragmath
DragMath having been placed in /lib/dragmath, what is the intended abode of asciimathml and shouldn;t the locations demonstrate consistency, as per the MDLs that address dragmath and asciimath
Since you have been fiddling HEAD vis-a-vis DragMath, have you also now changed adminlib.php as previously suggested (forum postings seem to suggest that you did this but I don't see the line in adminlib.php)
who will close the half dozen MDL's regarding dragmath that this MDL has rendered moot.... it would seem that at least things should be linked and tagged as closed since those tracking the existing MDL's would have no clue that things took a hard right.....

Petr Skoda committed 1 file to 'Moodle CVS' - 16/Jun/09 04:00 PM

MDL-19211 adding forgotten dragmath in legacy editors

MODIFY

lib/editor/tinymce/extra/Attic/tinymce.js.php

Rev. 1.7

(+1 -1 lines)

[ Permalink | « Hide ]

Petr Skoda added a comment - 16/Jun/09 04:07 PM

1/ there can not be "common" in editor directory because we have editor plugins there, whoever invented it forgot how our plugins work

2/ lib is the right place for imported libraries, it helps with maintenance
3/ I did not want to be maintainer of editor integrations but unfortunately nobody was working on editor integrations

4/ my current priority is to finalize editor embedding and only then start dealing with editor extensions, sorry if I broke anything

5/ each imported library MUST have readme_moodle.txt which includes list of all changes, import steps but also the maintainer!
6/ I do not understand what is your problem with 0.7.7, I took it from http://www.dragmath.bham.ac.uk/ which was at the time the latest version, the previous version was much older

Petr Skoda made changes - 16/Jun/09 04:26 PM

Field	Original Value	New Value
Link		This issue has a non-specific relationship to MDL-19521 [ MDL-19521 ]

[ Permalink | « Hide ]

Marc Grober added a comment - 18/Jun/09 02:30 AM

In fact I initially argued for dragmath and asciimath to be located in /lib/common but was overruled by Matthieu... There were also some editor recommendations and demonstrations by Mauno (pretty exciting stuff) that were set aside at the time (gee, almost a year ago now??).... i.e. there were people working on editor integrations.....

if dragmath is in lib/dragmath, then can we expect that asciimath will be in lib/asciimath?

Dragmath 0.7.7 was broken (a new fix in the code to address implied multiplication apparently broke another function), Alex released 0.7.7.1 to resolve the issue and I created a fresh zip for moodlers. 0.7.8 was released to address java console errors MK was seeing as he developed SEE, his integration of dragmath, asciimath, and svg with tinyMCE. Have you reviewed his work?

[ Permalink | « Hide ]

Mauno Korpelainen added a comment - 19/Jun/09 09:21 PM

Hi Marc and Petr,

you have written so many new tracker issues during my 2 holiday weeks that it is hard to follow all of them - anyway some comments in http://tracker.moodle.org/browse/MDL-19516 ...

I'm not worried about different plugin structure of moodle 2.0 and previous versions - or different integration methods, different editors etc...

Marc,

I'm really pleased to see Petr taking care of editor code and plugins - I suppose he was not aware of your role and we have had so many different test integrations (trials) during the last few years (starting from Janne's work, my versions, Glen's version, OU version, Mathieu's moodle 2.0 version etc) that most likely nobody has tested all of them - not to mention math plugins etc.

I am happy with any system that is stable and flexible enough for creating and using great features of moodle - both old and new ones... and I can change my files according to each version if needed...

Petr Skoda committed 9 files to 'Moodle CVS' - 20/Jun/09 07:00 PM

MDL-19211, ~~MDL-19544~~ improved editor embedding, media and dragmath enabled only when moodle configuration and current user permissions allow it to work 100%

MODIFY	lib/weblib.php	Rev. 1.1270	(+2 -3 lines)
DEL	lib/editor/tinymce/extra/Attic/tinymce.js.php	Rev. 1.8	(+0 -0 lines)
ADD	lib/editor/tinymce/extra/tinymce_utils.js	Rev. 1.1	(+0 -0 lines)
MODIFY	lib/editor/textarea/lib.php	Rev. 1.4	(+2 -10 lines)
MODIFY	lib/editorlib.php	Rev. 1.15	(+3 -13 lines)
MODIFY	lib/editor/tinymce/lib.php	Rev. 1.5	(+77 -14 lines)
MODIFY	mod/data/templates.php	Rev. 1.81	(+2 -8 lines)
MODIFY	lib/form/editor.php	Rev. 1.15	(+9 -12 lines)
MODIFY	lib/adminlib.php	Rev. 1.365	(+2 -3 lines)

All content on this web site is made available under the GNU General Public License, unless otherwise stated.