Moodle

Saving tags only on the question wizardpage that contain them normally first one as in calculated

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 2.0
  • Component/s: Questions
  • Labels:
    None
  • Affected Branches:
    MOODLE_20_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

There is an error when using second and third page of calculated question editing as there is no tags on theses pages.
So question.php line 208
if (!empty($CFG->usetags)) { require_once($CFG->dirroot.'/tag/lib.php'); tag_set('question', $question->id, $fromform->tags); }
should be changed to

if (!empty($CFG->usetags) && isset($fromform->tags)) { require_once($CFG->dirroot.'/tag/lib.php'); tag_set('question', $question->id, $fromform->tags); } }

I will CVs the correction in the next days (back to work tuesday).

Activity

Hide
Pierre Pichet added a comment -

Seems to work correctly

Show
Pierre Pichet added a comment - Seems to work correctly

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: