Issue Details (XML | Word | Printable)

Key: MDL-19288
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Blocker Blocker
Assignee: Petr Skoda
Reporter: Petr Skoda
Votes: 0
Watchers: 3
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Context and modinfo caching regressions on large sites

Created: 24/May/09 04:00 AM   Updated: 17/Oct/09 12:20 AM
Return to search
Component/s: Roles
Affects Version/s: 1.9.5
Fix Version/s: 1.9.6

Issue Links:
Relates
 

Participants: Colin Campbell, Petr Skoda and Sam Hemelryk
Security Level: None
QA Assignee: Sam Hemelryk
Resolved date: 24/May/09
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE


 Description  « Hide
the array_shift() call is not correct because it reorders the array - see MDL-18768

From MDL-18768, by Colin Campbell:
I am running into issues with this fix. The array_shift function renumbers numeric indexes. Consequently, as soon as we reach MAX_MODINFO_CACHE_SIZE in get_fast_modinfo, array_shift converts the cache keys from the course ids originally used to index the cache to sequential integers starting with zero. This causes all sorts of bad things to happen.


 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Petr Skoda made changes - 24/May/09 04:00 AM
Field Original Value New Value
Link This issue has a non-specific relationship to MDL-18768 [ MDL-18768 ]
Petr Skoda made changes - 24/May/09 04:09 AM
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Petr Skoda made changes - 24/May/09 04:15 AM
Summary context caching returns returns incorrect data Context caching breaks on large sites
Petr Skoda made changes - 24/May/09 04:16 AM
Description the array_shift() call is not correct because it reorders the array - see MDL-18768 the array_shift() call is not correct because it reorders the array - see MDL-18768

From MDL-18768, by Colin Campbell:
I am running into issues with this fix. The array_shift function renumbers numeric indexes. Consequently, as soon as we reach MAX_MODINFO_CACHE_SIZE in get_fast_modinfo, array_shift converts the cache keys from the course ids originally used to index the cache to sequential integers starting with zero. This causes all sorts of bad things to happen.
Petr Skoda made changes - 24/May/09 03:14 PM
Status Resolved [ 5 ] Reopened [ 4 ]
Resolution Fixed [ 1 ]
Petr Skoda made changes - 24/May/09 03:24 PM
Summary Context caching breaks on large sites Context and modinfo caching breaks on large sites
Petr Skoda made changes - 24/May/09 03:25 PM
Summary Context and modinfo caching breaks on large sites Context and modinfo caching regressions on large sites
Petr Skoda made changes - 24/May/09 03:26 PM
Status Reopened [ 4 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Sam Hemelryk made changes - 02/Jun/09 09:47 AM
Status Resolved [ 5 ] Closed [ 6 ]
QA Assignee samhemelryk
Jens Eremie made changes - 17/Oct/09 12:20 AM
Link This issue has a non-specific relationship to MDL-19702 [ MDL-19702 ]