Issue Details (XML | Word | Printable)

Key: MDL-19323
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Petr Škoda (skodak)
Reporter: Daniel Neis
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Problems with localized floats in new 1.9.5 gradebook code

Created: 28/May/09 10:57 PM   Updated: 03/Jun/09 04:46 PM
Component/s: General, Usability
Affects Version/s: 1.9.5
Fix Version/s: 1.9.6

File Attachments: 1. File mdl-localized-param-number.diff (0.6 kB)


Participants: Daniel Neis, Petr Škoda (skodak) and Sam Hemelryk
Security Level: None
QA Assignee: Sam Hemelryk
Resolved date: 30/May/09
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE


 Description  « Hide
While working in the gradebook, some users reported that it was not accepting "aggregationcoef" with commas, altough they are showed this way on the interface. Debugging the problem, i found that it is on the PARAM_NUMBER, that only does a type cast on $param.
To work with localized numbers, it must first perform a replace of 'descsep' with '.' and then do the cast.
There is a patch attached to correct this issue.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Petr Škoda (skodak) added a comment - 28/May/09 11:47 PM
The problem here is that the clean_param is used before setting up of current language, so it would have to guess which is not nice at all.

I suppose the aggregation problem is a recent regression, going to review it soon...


Petr Škoda (skodak) added a comment - 30/May/09 01:25 AM
I have reviewed the new gradebook code and found several problems there, renaming this issue to reflect this, fixes should be available in next weekly build

Petr Škoda (skodak) added a comment - 30/May/09 09:01 PM
should be working now fine, thanks for the report

Sam Hemelryk added a comment - 03/Jun/09 04:46 PM
Tested and confirmed working. Thanks