Moodle

Problems with localized floats in new 1.9.5 gradebook code

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.9.5
  • Fix Version/s: 1.9.6
  • Component/s: General, Usability
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

While working in the gradebook, some users reported that it was not accepting "aggregationcoef" with commas, altough they are showed this way on the interface. Debugging the problem, i found that it is on the PARAM_NUMBER, that only does a type cast on $param.
To work with localized numbers, it must first perform a replace of 'descsep' with '.' and then do the cast.
There is a patch attached to correct this issue.

Activity

Hide
Petr Škoda (skodak) added a comment -

The problem here is that the clean_param is used before setting up of current language, so it would have to guess which is not nice at all.

I suppose the aggregation problem is a recent regression, going to review it soon...

Show
Petr Škoda (skodak) added a comment - The problem here is that the clean_param is used before setting up of current language, so it would have to guess which is not nice at all. I suppose the aggregation problem is a recent regression, going to review it soon...
Hide
Petr Škoda (skodak) added a comment -

I have reviewed the new gradebook code and found several problems there, renaming this issue to reflect this, fixes should be available in next weekly build

Show
Petr Škoda (skodak) added a comment - I have reviewed the new gradebook code and found several problems there, renaming this issue to reflect this, fixes should be available in next weekly build
Hide
Petr Škoda (skodak) added a comment -

should be working now fine, thanks for the report

Show
Petr Škoda (skodak) added a comment - should be working now fine, thanks for the report
Hide
Sam Hemelryk added a comment -

Tested and confirmed working. Thanks

Show
Sam Hemelryk added a comment - Tested and confirmed working. Thanks

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: