Moodle

Advanced search does not work on Global search

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Won't Fix
  • Affects Version/s: 1.9.5
  • Fix Version/s: None
  • Component/s: Global search
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE

Description

Advanced search (Search option) does not work.

Patch is as follows;

in search/query.php

if (strlen(trim($adv->canappear)) > 0) { $query_string .= ' '.implode(' ', preg_split("/[\s,;]+/", $adv->canappear)); }

// add module restriction
// (Shirai141): coment out these lines
// $doctypestr = get_string('doctype', 'search');
// $titlestr = get_string('title', 'search');
// $authorstr = get_string('author', 'search');
// (Shirai141): add from here
$doctypestr = 'doctype';
$titlestr = 'title';
$authorstr = 'author';
// (Shirai135): add to here
if ($adv->module != 'all') {
$query_string .= " +{$doctypestr}:".$adv->module;
}
------------
get_string('titie', 'search') will return 'Title' in English environment and will return '????' in Japanese environment!!!

Issue Links

Activity

Hide
Valery Fremaux added a comment -

This is actually not a feature I examined a lot. Miss of time and fellows to animate that work !!

Now I have one

I integrate ASAP and make confirmation tests...

Cheers.

Show
Valery Fremaux added a comment - This is actually not a feature I examined a lot. Miss of time and fellows to animate that work !! Now I have one I integrate ASAP and make confirmation tests... Cheers.
Hide
Tatsuya Shirai added a comment -

I think that this issue is made clear by Valery too. No problem.

Show
Tatsuya Shirai added a comment - I think that this issue is made clear by Valery too. No problem.
Hide
Michael de Raadt added a comment -

Thanks for reporting this issue.

We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported.

If you believe that this issue is still relevant to current versions (2.1 and beyond), please comment on the issue. Issues left inactive for a further month will be closed.

Michael d;

lqjjLKA0p6

Show
Michael de Raadt added a comment - Thanks for reporting this issue. We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported. If you believe that this issue is still relevant to current versions (2.1 and beyond), please comment on the issue. Issues left inactive for a further month will be closed. Michael d; lqjjLKA0p6
Hide
Michael de Raadt added a comment -

I'm closing this issue as it appears to have become inactive and is probably not relevant to a current supported version. If you are encountering this problem or one similar, please launch a new issue.

Show
Michael de Raadt added a comment - I'm closing this issue as it appears to have become inactive and is probably not relevant to a current supported version. If you are encountering this problem or one similar, please launch a new issue.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: