Moodle

Discrepancies between plugins declared in get_plugin_types() and detected by get_db_directories()

Details

  • Database:
    Any
  • Difficulty:
    Moderate
  • Affected Branches:
    MOODLE_20_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

Right now we have one core function:

get_plugin_types()

that returns all the plugins supported by moodle. It's used in upgrade code to look for upgrades under all plugins.

In the other side, we have the function:

get_db_directories()

that returns all the directories where we can found database install/upgrade scripts (used by the xmldb editor, database manager...)

And right now, both functions are 100% separate, having to keep such lists maintained manually.

Solution: Let's modify get_db_directories() in order to use get_plugin_types() to know about all the dirs being candidates to have install/upgrade/xmldb editor... scripts recognising the same plugins always.

Issue Links

This issue has a non-specific relationship to:
MDL-16059 XMLDB editor does not generate upgrade_mod_savepoint calls Minor Closed
This issue has been marked as being related by:
MDL-16438 centralise information about plugins to avoid duplication Minor Closed

Activity

Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Done, now get_db_directories() is using get_plugin_types(), so the latter is the only place where supported plugins and paths need to be defined.

Resolving as fixed. Ciao

Show
Eloy Lafuente (stronk7) added a comment - Done, now get_db_directories() is using get_plugin_types(), so the latter is the only place where supported plugins and paths need to be defined. Resolving as fixed. Ciao

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.