Moodle

avoiding multiple running of imsenterprise enrol.php

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 1.9.5
  • Fix Version/s: STABLE backlog
  • Component/s: Enrolments
  • Labels:
    None
  • Difficulty:
    Easy
  • Affected Branches:
    MOODLE_19_STABLE

Description

If the current enrol/imsenterprise/enrol.php is executed from Moodle cron job and the imsenterprise file is big enough,
the same imsenterprise file is processed many times, which can cause disastrous result like many courses being multiply created (and the cleaning up will take long time manually...)
This can be easily avoided by moving the location of
set_config('enrol_ims_prev_time', $filemtime);
set_config('enrol_ims_prev_md5', $md5);
set_config('enrol_ims_prev_path', $filename);
to an earlier place.

The patch for this modification is attached to this posting.

Issue Links

Activity

Hide
Mark Webster added a comment -

The one-line fix in MDL-13916 works very nicely for us in 1.9.7. This fix is also required if you are using the Minted IMS enrollment module.

Show
Mark Webster added a comment - The one-line fix in MDL-13916 works very nicely for us in 1.9.7. This fix is also required if you are using the Minted IMS enrollment module.
Hide
Dan Poltawski added a comment -

Seems sensible, but Assigning to moodle.com as i've not had a chance to look at this and don't have an ims enteprise enrol file

Show
Dan Poltawski added a comment - Seems sensible, but Assigning to moodle.com as i've not had a chance to look at this and don't have an ims enteprise enrol file

People

Vote (1)
Watch (2)

Dates

  • Created:
    Updated: