Moodle

Review all upgrade.php scripts in 2.0 to confirm all them have correct savepoints in use

Details

  • Type: Task Task
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 2.0
  • Component/s: Database SQL/XMLDB, Installation
  • Labels:
    None
  • Affected Branches:
    MOODLE_20_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

I've found some upgrade scripts in 2.0 not using the new savepoints (which use is highly recommended to run upgrade safer if something fails in any step).

Review adding the missing calls to savepoints.

Ciao

Issue Links

This issue has a non-specific relationship to:
MDL-16059 XMLDB editor does not generate upgrade_mod_savepoint calls Minor Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

db/upgrade.php basic parser available at: http://cvs.moodle.org/contrib/tools/check_upgrade_savepoints/

tomorrow I'll perform the automatic/manual review of this bug, to ensure everything works as expected. Ciao

Show
Eloy Lafuente (stronk7) added a comment - db/upgrade.php basic parser available at: http://cvs.moodle.org/contrib/tools/check_upgrade_savepoints/ tomorrow I'll perform the automatic/manual review of this bug, to ensure everything works as expected. Ciao
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Couldn't resist to paste here the output of the checker execution (note it isn't fully tested). What a plague of errors/warns!

mbp:moodle_head stronk7$ php check_upgrade_savepoints.php

  • /Users/stronk7/cvs_moodle/moodle_head/blocks/activity_modules/db/upgrade.php:
    + NOTE: cannot find 'if' blocks within the upgrade function
  • /Users/stronk7/cvs_moodle/moodle_head/blocks/admin/db/upgrade.php:
    + NOTE: cannot find 'if' blocks within the upgrade function
  • /Users/stronk7/cvs_moodle/moodle_head/blocks/calendar_month/db/upgrade.php:
    + NOTE: cannot find 'if' blocks within the upgrade function
  • /Users/stronk7/cvs_moodle/moodle_head/blocks/calendar_upcoming/db/upgrade.php:
    + NOTE: cannot find 'if' blocks within the upgrade function
  • /Users/stronk7/cvs_moodle/moodle_head/blocks/course_list/db/upgrade.php:
    + NOTE: cannot find 'if' blocks within the upgrade function
  • /Users/stronk7/cvs_moodle/moodle_head/blocks/course_summary/db/upgrade.php:
    + NOTE: cannot find 'if' blocks within the upgrade function
  • /Users/stronk7/cvs_moodle/moodle_head/blocks/news_items/db/upgrade.php:
    + NOTE: cannot find 'if' blocks within the upgrade function
  • /Users/stronk7/cvs_moodle/moodle_head/blocks/online_users/db/upgrade.php:
    + NOTE: cannot find 'if' blocks within the upgrade function
  • /Users/stronk7/cvs_moodle/moodle_head/blocks/participants/db/upgrade.php:
    + NOTE: cannot find 'if' blocks within the upgrade function
  • /Users/stronk7/cvs_moodle/moodle_head/blocks/recent_activity/db/upgrade.php:
    + NOTE: cannot find 'if' blocks within the upgrade function
  • /Users/stronk7/cvs_moodle/moodle_head/blocks/rss_client/db/upgrade.php:
    + ERROR: Detected more 'if' blocks (1) than 'savepoint' calls (0)
    + versions in upgrade blocks properly ordered
    + ERROR: version 2007080100 is missing corresponding savepoint call
  • /Users/stronk7/cvs_moodle/moodle_head/blocks/search/db/upgrade.php:
    + NOTE: cannot find 'if' blocks within the upgrade function
  • /Users/stronk7/cvs_moodle/moodle_head/blocks/search_forums/db/upgrade.php:
    + NOTE: cannot find 'if' blocks within the upgrade function
  • /Users/stronk7/cvs_moodle/moodle_head/blocks/section_links/db/upgrade.php:
    + NOTE: cannot find 'if' blocks within the upgrade function
  • /Users/stronk7/cvs_moodle/moodle_head/blocks/social_activities/db/upgrade.php:
    + NOTE: cannot find 'if' blocks within the upgrade function
  • /Users/stronk7/cvs_moodle/moodle_head/enrol/authorize/db/upgrade.php:
    + ERROR: Detected more 'if' blocks (2) than 'savepoint' calls (0)
    + versions in upgrade blocks properly ordered
    + ERROR: version 2008092700 is missing corresponding savepoint call
    + ERROR: version 2009042700 is missing corresponding savepoint call
  • /Users/stronk7/cvs_moodle/moodle_head/enrol/paypal/db/upgrade.php:
    + NOTE: cannot find 'if' blocks within the upgrade function
  • /Users/stronk7/cvs_moodle/moodle_head/lib/db/upgrade.php:
    + ERROR: Detected more 'if' blocks (102) than 'savepoint' calls (101)
    + versions in upgrade blocks properly ordered
    + ERROR: version 2008051200 is missing corresponding savepoint call
  • /Users/stronk7/cvs_moodle/moodle_head/message/output/email/db/upgrade.php:
    + ERROR: Detected more 'if' blocks (1) than 'savepoint' calls (0)
    + versions in upgrade blocks properly ordered
    + ERROR: version 2008072401 is missing corresponding savepoint call
  • /Users/stronk7/cvs_moodle/moodle_head/message/output/jabber/db/upgrade.php:
    + ERROR: Detected more 'if' blocks (1) than 'savepoint' calls (0)
    + versions in upgrade blocks properly ordered
    + ERROR: version 2008072401 is missing corresponding savepoint call
  • /Users/stronk7/cvs_moodle/moodle_head/message/output/popup/db/upgrade.php:
    + ERROR: Detected more 'if' blocks (1) than 'savepoint' calls (0)
    + versions in upgrade blocks properly ordered
    + ERROR: version 2008072401 is missing corresponding savepoint call
  • /Users/stronk7/cvs_moodle/moodle_head/mod/assignment/db/upgrade.php:
    + found 4 matching 'if' blocks and 'savepoint' calls
    + versions in upgrade blocks properly ordered
    + versions in savepoint calls properly matching upgrade blocks
  • /Users/stronk7/cvs_moodle/moodle_head/mod/chat/db/upgrade.php:
    + found 3 matching 'if' blocks and 'savepoint' calls
    + versions in upgrade blocks properly ordered
    + versions in savepoint calls properly matching upgrade blocks
  • /Users/stronk7/cvs_moodle/moodle_head/mod/choice/db/upgrade.php:
    + found 2 matching 'if' blocks and 'savepoint' calls
    + versions in upgrade blocks properly ordered
    + versions in savepoint calls properly matching upgrade blocks
  • /Users/stronk7/cvs_moodle/moodle_head/mod/data/db/upgrade.php:
    + found 6 matching 'if' blocks and 'savepoint' calls
    + versions in upgrade blocks properly ordered
    + versions in savepoint calls properly matching upgrade blocks
  • /Users/stronk7/cvs_moodle/moodle_head/mod/feedback/db/upgrade.php:
    + found 13 matching 'if' blocks and 'savepoint' calls
    + versions in upgrade blocks properly ordered
    + versions in savepoint calls properly matching upgrade blocks
  • /Users/stronk7/cvs_moodle/moodle_head/mod/forum/db/upgrade.php:
    + WARN: Detected less 'if' blocks (11) than 'savepoint' calls (12). Repeated savepoints?
    + versions in upgrade blocks properly ordered
    + versions in savepoint calls properly matching upgrade blocks
  • /Users/stronk7/cvs_moodle/moodle_head/mod/glossary/db/upgrade.php:
    + found 8 matching 'if' blocks and 'savepoint' calls
    + versions in upgrade blocks properly ordered
    + versions in savepoint calls properly matching upgrade blocks
  • /Users/stronk7/cvs_moodle/moodle_head/mod/hotpot/db/upgrade.php:
    + ERROR: Detected more 'if' blocks (2) than 'savepoint' calls (0)
    + versions in upgrade blocks properly ordered
    + ERROR: version 2007101511 is missing corresponding savepoint call
    + ERROR: version 2008011200 is missing corresponding savepoint call
  • /Users/stronk7/cvs_moodle/moodle_head/mod/label/db/upgrade.php:
    + WARN: Detected less 'if' blocks (2) than 'savepoint' calls (3). Repeated savepoints?
    + versions in upgrade blocks properly ordered
    + versions in savepoint calls properly matching upgrade blocks
  • /Users/stronk7/cvs_moodle/moodle_head/mod/lesson/db/upgrade.php:
    + found 2 matching 'if' blocks and 'savepoint' calls
    + versions in upgrade blocks properly ordered
    + versions in savepoint calls properly matching upgrade blocks
  • /Users/stronk7/cvs_moodle/moodle_head/mod/quiz/db/upgrade.php:
    + found 20 matching 'if' blocks and 'savepoint' calls
    + versions in upgrade blocks properly ordered
    + versions in savepoint calls properly matching upgrade blocks
  • /Users/stronk7/cvs_moodle/moodle_head/mod/quiz/report/overview/db/upgrade.php:
    + ERROR: Detected more 'if' blocks (2) than 'savepoint' calls (0)
    + versions in upgrade blocks properly ordered
    + ERROR: version 2008062700 is missing corresponding savepoint call
    + ERROR: version 2009030500 is missing corresponding savepoint call
  • /Users/stronk7/cvs_moodle/moodle_head/mod/quiz/report/statistics/db/upgrade.php:
    + ERROR: Detected more 'if' blocks (9) than 'savepoint' calls (0)
    + versions in upgrade blocks properly ordered
    + ERROR: version 2008072401 is missing corresponding savepoint call
    + ERROR: version 2008072500 is missing corresponding savepoint call
    + ERROR: version 2008072800 is missing corresponding savepoint call
    + ERROR: version 2008072801 is missing corresponding savepoint call
    + ERROR: version 2008081500 is missing corresponding savepoint call
    + ERROR: version 2008082600 is missing corresponding savepoint call
    + ERROR: version 2008090500 is missing corresponding savepoint call
    + ERROR: version 2008111000 is missing corresponding savepoint call
    + ERROR: version 2008112100 is missing corresponding savepoint call
  • /Users/stronk7/cvs_moodle/moodle_head/mod/resource/db/upgrade.php:
    + found 2 matching 'if' blocks and 'savepoint' calls
    + versions in upgrade blocks properly ordered
    + versions in savepoint calls properly matching upgrade blocks
  • /Users/stronk7/cvs_moodle/moodle_head/mod/scorm/db/upgrade.php:
    + found 14 matching 'if' blocks and 'savepoint' calls
    + versions in upgrade blocks properly ordered
    + versions in savepoint calls properly matching upgrade blocks
  • /Users/stronk7/cvs_moodle/moodle_head/mod/survey/db/upgrade.php:
    + found 1 matching 'if' blocks and 'savepoint' calls
    + versions in upgrade blocks properly ordered
    + versions in savepoint calls properly matching upgrade blocks
  • /Users/stronk7/cvs_moodle/moodle_head/mod/wiki/db/upgrade.php:
    + found 3 matching 'if' blocks and 'savepoint' calls
    + versions in upgrade blocks properly ordered
    + versions in savepoint calls properly matching upgrade blocks
  • /Users/stronk7/cvs_moodle/moodle_head/portfolio/type/mahara/db/upgrade.php:
    + NOTE: cannot find 'if' blocks within the upgrade function
  • /Users/stronk7/cvs_moodle/moodle_head/question/type/calculated/db/upgrade.php:
    + found 1 matching 'if' blocks and 'savepoint' calls
    + versions in upgrade blocks properly ordered
    + versions in savepoint calls properly matching upgrade blocks
  • /Users/stronk7/cvs_moodle/moodle_head/question/type/essay/db/upgrade.php:
    + NOTE: cannot find 'if' blocks within the upgrade function
  • /Users/stronk7/cvs_moodle/moodle_head/question/type/match/db/upgrade.php:
    + NOTE: cannot find 'if' blocks within the upgrade function
  • /Users/stronk7/cvs_moodle/moodle_head/question/type/multianswer/db/upgrade.php:
    + ERROR: Detected more 'if' blocks (1) than 'savepoint' calls (0)
    + versions in upgrade blocks properly ordered
    + ERROR: version 2008050800 is missing corresponding savepoint call
  • /Users/stronk7/cvs_moodle/moodle_head/question/type/multichoice/db/upgrade.php:
    + found 1 matching 'if' blocks and 'savepoint' calls
    + versions in upgrade blocks properly ordered
    + versions in savepoint calls properly matching upgrade blocks
  • /Users/stronk7/cvs_moodle/moodle_head/question/type/numerical/db/upgrade.php:
    + NOTE: cannot find 'if' blocks within the upgrade function
  • /Users/stronk7/cvs_moodle/moodle_head/question/type/randomsamatch/db/upgrade.php:
    + NOTE: cannot find 'if' blocks within the upgrade function
  • /Users/stronk7/cvs_moodle/moodle_head/question/type/shortanswer/db/upgrade.php:
    + NOTE: cannot find 'if' blocks within the upgrade function
  • /Users/stronk7/cvs_moodle/moodle_head/question/type/truefalse/db/upgrade.php:
    + NOTE: cannot find 'if' blocks within the upgrade function
  • /Users/stronk7/cvs_moodle/moodle_head/repository/local/db/upgrade.php:
    + ERROR: Detected more 'if' blocks (1) than 'savepoint' calls (0)
    + versions in upgrade blocks properly ordered
    + ERROR: version 2009031000 is missing corresponding savepoint call
  • /Users/stronk7/cvs_moodle/moodle_head/repository/upload/db/upgrade.php:
    + ERROR: Detected more 'if' blocks (1) than 'savepoint' calls (0)
    + versions in upgrade blocks properly ordered
    + ERROR: version 2009031000 is missing corresponding savepoint call
Show
Eloy Lafuente (stronk7) added a comment - Couldn't resist to paste here the output of the checker execution (note it isn't fully tested). What a plague of errors/warns! mbp:moodle_head stronk7$ php check_upgrade_savepoints.php
  • /Users/stronk7/cvs_moodle/moodle_head/blocks/activity_modules/db/upgrade.php: + NOTE: cannot find 'if' blocks within the upgrade function
  • /Users/stronk7/cvs_moodle/moodle_head/blocks/admin/db/upgrade.php: + NOTE: cannot find 'if' blocks within the upgrade function
  • /Users/stronk7/cvs_moodle/moodle_head/blocks/calendar_month/db/upgrade.php: + NOTE: cannot find 'if' blocks within the upgrade function
  • /Users/stronk7/cvs_moodle/moodle_head/blocks/calendar_upcoming/db/upgrade.php: + NOTE: cannot find 'if' blocks within the upgrade function
  • /Users/stronk7/cvs_moodle/moodle_head/blocks/course_list/db/upgrade.php: + NOTE: cannot find 'if' blocks within the upgrade function
  • /Users/stronk7/cvs_moodle/moodle_head/blocks/course_summary/db/upgrade.php: + NOTE: cannot find 'if' blocks within the upgrade function
  • /Users/stronk7/cvs_moodle/moodle_head/blocks/news_items/db/upgrade.php: + NOTE: cannot find 'if' blocks within the upgrade function
  • /Users/stronk7/cvs_moodle/moodle_head/blocks/online_users/db/upgrade.php: + NOTE: cannot find 'if' blocks within the upgrade function
  • /Users/stronk7/cvs_moodle/moodle_head/blocks/participants/db/upgrade.php: + NOTE: cannot find 'if' blocks within the upgrade function
  • /Users/stronk7/cvs_moodle/moodle_head/blocks/recent_activity/db/upgrade.php: + NOTE: cannot find 'if' blocks within the upgrade function
  • /Users/stronk7/cvs_moodle/moodle_head/blocks/rss_client/db/upgrade.php: + ERROR: Detected more 'if' blocks (1) than 'savepoint' calls (0) + versions in upgrade blocks properly ordered + ERROR: version 2007080100 is missing corresponding savepoint call
  • /Users/stronk7/cvs_moodle/moodle_head/blocks/search/db/upgrade.php: + NOTE: cannot find 'if' blocks within the upgrade function
  • /Users/stronk7/cvs_moodle/moodle_head/blocks/search_forums/db/upgrade.php: + NOTE: cannot find 'if' blocks within the upgrade function
  • /Users/stronk7/cvs_moodle/moodle_head/blocks/section_links/db/upgrade.php: + NOTE: cannot find 'if' blocks within the upgrade function
  • /Users/stronk7/cvs_moodle/moodle_head/blocks/social_activities/db/upgrade.php: + NOTE: cannot find 'if' blocks within the upgrade function
  • /Users/stronk7/cvs_moodle/moodle_head/enrol/authorize/db/upgrade.php: + ERROR: Detected more 'if' blocks (2) than 'savepoint' calls (0) + versions in upgrade blocks properly ordered + ERROR: version 2008092700 is missing corresponding savepoint call + ERROR: version 2009042700 is missing corresponding savepoint call
  • /Users/stronk7/cvs_moodle/moodle_head/enrol/paypal/db/upgrade.php: + NOTE: cannot find 'if' blocks within the upgrade function
  • /Users/stronk7/cvs_moodle/moodle_head/lib/db/upgrade.php: + ERROR: Detected more 'if' blocks (102) than 'savepoint' calls (101) + versions in upgrade blocks properly ordered + ERROR: version 2008051200 is missing corresponding savepoint call
  • /Users/stronk7/cvs_moodle/moodle_head/message/output/email/db/upgrade.php: + ERROR: Detected more 'if' blocks (1) than 'savepoint' calls (0) + versions in upgrade blocks properly ordered + ERROR: version 2008072401 is missing corresponding savepoint call
  • /Users/stronk7/cvs_moodle/moodle_head/message/output/jabber/db/upgrade.php: + ERROR: Detected more 'if' blocks (1) than 'savepoint' calls (0) + versions in upgrade blocks properly ordered + ERROR: version 2008072401 is missing corresponding savepoint call
  • /Users/stronk7/cvs_moodle/moodle_head/message/output/popup/db/upgrade.php: + ERROR: Detected more 'if' blocks (1) than 'savepoint' calls (0) + versions in upgrade blocks properly ordered + ERROR: version 2008072401 is missing corresponding savepoint call
  • /Users/stronk7/cvs_moodle/moodle_head/mod/assignment/db/upgrade.php: + found 4 matching 'if' blocks and 'savepoint' calls + versions in upgrade blocks properly ordered + versions in savepoint calls properly matching upgrade blocks
  • /Users/stronk7/cvs_moodle/moodle_head/mod/chat/db/upgrade.php: + found 3 matching 'if' blocks and 'savepoint' calls + versions in upgrade blocks properly ordered + versions in savepoint calls properly matching upgrade blocks
  • /Users/stronk7/cvs_moodle/moodle_head/mod/choice/db/upgrade.php: + found 2 matching 'if' blocks and 'savepoint' calls + versions in upgrade blocks properly ordered + versions in savepoint calls properly matching upgrade blocks
  • /Users/stronk7/cvs_moodle/moodle_head/mod/data/db/upgrade.php: + found 6 matching 'if' blocks and 'savepoint' calls + versions in upgrade blocks properly ordered + versions in savepoint calls properly matching upgrade blocks
  • /Users/stronk7/cvs_moodle/moodle_head/mod/feedback/db/upgrade.php: + found 13 matching 'if' blocks and 'savepoint' calls + versions in upgrade blocks properly ordered + versions in savepoint calls properly matching upgrade blocks
  • /Users/stronk7/cvs_moodle/moodle_head/mod/forum/db/upgrade.php: + WARN: Detected less 'if' blocks (11) than 'savepoint' calls (12). Repeated savepoints? + versions in upgrade blocks properly ordered + versions in savepoint calls properly matching upgrade blocks
  • /Users/stronk7/cvs_moodle/moodle_head/mod/glossary/db/upgrade.php: + found 8 matching 'if' blocks and 'savepoint' calls + versions in upgrade blocks properly ordered + versions in savepoint calls properly matching upgrade blocks
  • /Users/stronk7/cvs_moodle/moodle_head/mod/hotpot/db/upgrade.php: + ERROR: Detected more 'if' blocks (2) than 'savepoint' calls (0) + versions in upgrade blocks properly ordered + ERROR: version 2007101511 is missing corresponding savepoint call + ERROR: version 2008011200 is missing corresponding savepoint call
  • /Users/stronk7/cvs_moodle/moodle_head/mod/label/db/upgrade.php: + WARN: Detected less 'if' blocks (2) than 'savepoint' calls (3). Repeated savepoints? + versions in upgrade blocks properly ordered + versions in savepoint calls properly matching upgrade blocks
  • /Users/stronk7/cvs_moodle/moodle_head/mod/lesson/db/upgrade.php: + found 2 matching 'if' blocks and 'savepoint' calls + versions in upgrade blocks properly ordered + versions in savepoint calls properly matching upgrade blocks
  • /Users/stronk7/cvs_moodle/moodle_head/mod/quiz/db/upgrade.php: + found 20 matching 'if' blocks and 'savepoint' calls + versions in upgrade blocks properly ordered + versions in savepoint calls properly matching upgrade blocks
  • /Users/stronk7/cvs_moodle/moodle_head/mod/quiz/report/overview/db/upgrade.php: + ERROR: Detected more 'if' blocks (2) than 'savepoint' calls (0) + versions in upgrade blocks properly ordered + ERROR: version 2008062700 is missing corresponding savepoint call + ERROR: version 2009030500 is missing corresponding savepoint call
  • /Users/stronk7/cvs_moodle/moodle_head/mod/quiz/report/statistics/db/upgrade.php: + ERROR: Detected more 'if' blocks (9) than 'savepoint' calls (0) + versions in upgrade blocks properly ordered + ERROR: version 2008072401 is missing corresponding savepoint call + ERROR: version 2008072500 is missing corresponding savepoint call + ERROR: version 2008072800 is missing corresponding savepoint call + ERROR: version 2008072801 is missing corresponding savepoint call + ERROR: version 2008081500 is missing corresponding savepoint call + ERROR: version 2008082600 is missing corresponding savepoint call + ERROR: version 2008090500 is missing corresponding savepoint call + ERROR: version 2008111000 is missing corresponding savepoint call + ERROR: version 2008112100 is missing corresponding savepoint call
  • /Users/stronk7/cvs_moodle/moodle_head/mod/resource/db/upgrade.php: + found 2 matching 'if' blocks and 'savepoint' calls + versions in upgrade blocks properly ordered + versions in savepoint calls properly matching upgrade blocks
  • /Users/stronk7/cvs_moodle/moodle_head/mod/scorm/db/upgrade.php: + found 14 matching 'if' blocks and 'savepoint' calls + versions in upgrade blocks properly ordered + versions in savepoint calls properly matching upgrade blocks
  • /Users/stronk7/cvs_moodle/moodle_head/mod/survey/db/upgrade.php: + found 1 matching 'if' blocks and 'savepoint' calls + versions in upgrade blocks properly ordered + versions in savepoint calls properly matching upgrade blocks
  • /Users/stronk7/cvs_moodle/moodle_head/mod/wiki/db/upgrade.php: + found 3 matching 'if' blocks and 'savepoint' calls + versions in upgrade blocks properly ordered + versions in savepoint calls properly matching upgrade blocks
  • /Users/stronk7/cvs_moodle/moodle_head/portfolio/type/mahara/db/upgrade.php: + NOTE: cannot find 'if' blocks within the upgrade function
  • /Users/stronk7/cvs_moodle/moodle_head/question/type/calculated/db/upgrade.php: + found 1 matching 'if' blocks and 'savepoint' calls + versions in upgrade blocks properly ordered + versions in savepoint calls properly matching upgrade blocks
  • /Users/stronk7/cvs_moodle/moodle_head/question/type/essay/db/upgrade.php: + NOTE: cannot find 'if' blocks within the upgrade function
  • /Users/stronk7/cvs_moodle/moodle_head/question/type/match/db/upgrade.php: + NOTE: cannot find 'if' blocks within the upgrade function
  • /Users/stronk7/cvs_moodle/moodle_head/question/type/multianswer/db/upgrade.php: + ERROR: Detected more 'if' blocks (1) than 'savepoint' calls (0) + versions in upgrade blocks properly ordered + ERROR: version 2008050800 is missing corresponding savepoint call
  • /Users/stronk7/cvs_moodle/moodle_head/question/type/multichoice/db/upgrade.php: + found 1 matching 'if' blocks and 'savepoint' calls + versions in upgrade blocks properly ordered + versions in savepoint calls properly matching upgrade blocks
  • /Users/stronk7/cvs_moodle/moodle_head/question/type/numerical/db/upgrade.php: + NOTE: cannot find 'if' blocks within the upgrade function
  • /Users/stronk7/cvs_moodle/moodle_head/question/type/randomsamatch/db/upgrade.php: + NOTE: cannot find 'if' blocks within the upgrade function
  • /Users/stronk7/cvs_moodle/moodle_head/question/type/shortanswer/db/upgrade.php: + NOTE: cannot find 'if' blocks within the upgrade function
  • /Users/stronk7/cvs_moodle/moodle_head/question/type/truefalse/db/upgrade.php: + NOTE: cannot find 'if' blocks within the upgrade function
  • /Users/stronk7/cvs_moodle/moodle_head/repository/local/db/upgrade.php: + ERROR: Detected more 'if' blocks (1) than 'savepoint' calls (0) + versions in upgrade blocks properly ordered + ERROR: version 2009031000 is missing corresponding savepoint call
  • /Users/stronk7/cvs_moodle/moodle_head/repository/upload/db/upgrade.php: + ERROR: Detected more 'if' blocks (1) than 'savepoint' calls (0) + versions in upgrade blocks properly ordered + ERROR: version 2009031000 is missing corresponding savepoint call
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Done, all WARN & ERROR messages are out. All out upgrade steps are properly using the corresponding savepoint function.

Resolving as fixed. We should run this monthly or so to have everything under control. Adding to my TODO.

Show
Eloy Lafuente (stronk7) added a comment - Done, all WARN & ERROR messages are out. All out upgrade steps are properly using the corresponding savepoint function. Resolving as fixed. We should run this monthly or so to have everything under control. Adding to my TODO.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.