Moodle

portfolion plugin instance name is not compatible with multilang

Details

  • Type: Sub-task Sub-task
  • Status: Open Open
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: 2.0
  • Fix Version/s: 2.0.8
  • Component/s: Portfolio API
  • Labels:
    None
  • Affected Branches:
    MOODLE_20_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

missing format_string() when printing name of portfolio plugin instance
and db field is too short

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Penny Leach added a comment -

How long does the db field need to be?

Show
Penny Leach added a comment - How long does the db field need to be?
Hide
Permalink
Petr Škoda (skodak) added a comment -

no idea, you have to ask Eloy

Show
Petr Škoda (skodak) added a comment - no idea, you have to ask Eloy
Hide
Permalink
Penny Leach added a comment -

Hi Eloy! Can you comment please

Show
Penny Leach added a comment - Hi Eloy! Can you comment please
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Are you talking about the portfolio_instance->name column? The name introduced by hand when one instance of one portfolio is created? (btw, not "one" instance but the "unique" one - seems that frontend doesn't allow multiple - severe limit IMO).

Anyway, do we really want to support multilang there? Well, it's 255cc now and that seems enough to store 3-4 langs (with all those "extra" cc needed by the syntax). I think we have support in for multilang in other 255cc varchar fields in Moodle right now.

The alternative would be to switch to text... but I think it's too much in this case. So +0.75 to process it (all output uses) with format_string(), leaving it as 255cc varchar. (I reserve the remaining +0.25 because I'm not sure if it's really important to have that info supporting multilang. For your decision).

Ciao

Show
Eloy Lafuente (stronk7) added a comment - Are you talking about the portfolio_instance->name column? The name introduced by hand when one instance of one portfolio is created? (btw, not "one" instance but the "unique" one - seems that frontend doesn't allow multiple - severe limit IMO). Anyway, do we really want to support multilang there? Well, it's 255cc now and that seems enough to store 3-4 langs (with all those "extra" cc needed by the syntax). I think we have support in for multilang in other 255cc varchar fields in Moodle right now. The alternative would be to switch to text... but I think it's too much in this case. So +0.75 to process it (all output uses) with format_string(), leaving it as 255cc varchar. (I reserve the remaining +0.25 because I'm not sure if it's really important to have that info supporting multilang. For your decision). Ciao
Hide
Permalink
Penny Leach added a comment -

> (btw, not "one" instance but the "unique" one - seems that frontend doesn't allow multiple - severe limit IMO).

Sorry, that's just wrong. Each portfolio plugin says whether it makes sense to allow multiple instances of the same plugin - boxnet and file download say "no" because there's no way to configure them differently - there's only one box.net. Mahara says yes, because Moodle could be connected to many Mahara's.

Re mutilang - I agree that 255 is enough - I don't know why Petr said it's not. I think text is definitely overkill. However agree about format_string.

Show
Penny Leach added a comment - > (btw, not "one" instance but the "unique" one - seems that frontend doesn't allow multiple - severe limit IMO). Sorry, that's just wrong. Each portfolio plugin says whether it makes sense to allow multiple instances of the same plugin - boxnet and file download say "no" because there's no way to configure them differently - there's only one box.net. Mahara says yes, because Moodle could be connected to many Mahara's. Re mutilang - I agree that 255 is enough - I don't know why Petr said it's not. I think text is definitely overkill. However agree about format_string.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.