[#MDL-19416] Quickforms is misusing old-style constructors - fatel error in our quickforms extension code in PHP 5.3

Issue Details (XML | Word | Printable)

Key:	MDL-19416
Type:	Sub-task
Status:	Closed
Resolution:	Fixed
Priority:	Blocker
Assignee:	Petr Skoda
Reporter:	Petr Skoda
Votes:	0
Watchers:	1

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

MDL-19415

Quickforms is misusing old-style constructors - fatel error in our quickforms extension code in PHP 5.3

Created: 07/Jun/09 05:23 PM Updated: 06/Oct/09 12:46 PM

Return to search

Component/s:

Forms Library

Affects Version/s:

1.9.5

Fix Version/s:

1.9.6, 2.0

File Attachments:

forms_constructors_19.patch (10 kB)
2.

forms_constructors_20.patch (10 kB)

Participants:	Dongsheng Cai, Nadav Kavalerchik and Petr Skoda
Security Level:	None
QA Assignee:	Dongsheng Cai
Resolved date:	14/Jun/09
Affected Branches:	MOODLE_19_STABLE
Fixed Branches:	MOODLE_19_STABLE, MOODLE_20_STABLE

Description

« Hide

Looks like following fragment is not valid any more:

$className = get_class($this);
$this->$className($arg[0], $arg[1], $arg[2], $arg[3], $arg[4]);

This weird use of constructor relies on presence of old-style constructors which is fatal in 5.3 :-(

All

Comments

Change History

Version Control

Sort Order:

Petr Skoda made changes - 07/Jun/09 05:41 PM

Field	Original Value	New Value
Attachment		forms_constructors_20.patch [ 17552 ]

Petr Skoda made changes - 08/Jun/09 02:09 AM

Summary

Quickforms is misusing old-style constructures - fatel error in PHP 5.3

Quickforms is misusing old-style constructors - fatel error in our quickforms extension code in PHP 5.3

Petr Skoda made changes - 08/Jun/09 02:10 AM

Attachment

forms_constructors_19.patch [ 17564 ]

Petr Skoda made changes - 14/Jun/09 01:25 AM

Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Resolved [ 5 ]

Dongsheng Cai made changes - 06/Oct/09 12:46 PM

Status	Resolved [ 5 ]	Closed [ 6 ]
QA Assignee		dongsheng

All content on this web site is made available under the GNU General Public License, unless otherwise stated.