Moodle

Quickforms is misusing old-style constructors - fatel error in our quickforms extension code in PHP 5.3

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 1.9.5
  • Fix Version/s: 1.9.6, 2.0
  • Component/s: Forms Library
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE, MOODLE_20_STABLE

Description

Looks like following fragment is not valid any more:

$className = get_class($this);
$this->$className($arg[0], $arg[1], $arg[2], $arg[3], $arg[4]);

This weird use of constructor relies on presence of old-style constructors which is fatal in 5.3

  1. forms_constructors_19.patch
    08/Jun/09 2:10 AM
    10 kB
    Petr Škoda (skodak)
  2. forms_constructors_20.patch
    07/Jun/09 5:41 PM
    10 kB
    Petr Škoda (skodak)

Issue Links

Activity

Hide
Petr Škoda (skodak) added a comment -

patch against head

Show
Petr Škoda (skodak) added a comment - patch against head
Hide
Petr Škoda (skodak) added a comment -

Attaching patch for 1.9x, please review and test

Show
Petr Škoda (skodak) added a comment - Attaching patch for 1.9x, please review and test
Hide
Petr Škoda (skodak) added a comment -

fixed

Show
Petr Škoda (skodak) added a comment - fixed
Hide
Nadav Kavalerchik added a comment -

worked for me on a 1.9.4 clean moodle install (with php 5.3 / debian)

thanks

Show
Nadav Kavalerchik added a comment - worked for me on a 1.9.4 clean moodle install (with php 5.3 / debian) thanks
Hide
Dongsheng Cai added a comment -

Worked, thanks Petr, close this issue

Show
Dongsheng Cai added a comment - Worked, thanks Petr, close this issue

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: