[#MDL-19418] ereg* is deprecated in PHP 5.3

Issue Details (XML | Word | Printable)

Key:	MDL-19418
Type:	Sub-task
Status:	Resolved
Resolution:	Fixed
Priority:	Minor
Assignee:	Nicolas Connault
Reporter:	Petr Skoda
Votes:	0
Watchers:	1

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

MDL-19415

ereg* is deprecated in PHP 5.3

Created: 07/Jun/09 06:45 PM Updated: 15/Aug/09 07:02 AM

Return to search

Component/s:

General

Affects Version/s:

1.9.5

Fix Version/s:

2.0

File Attachments:

MDL-19418.patch (64 kB)

Participants:	Nicolas Connault, Petr Skoda and Pierre Pichet
Security Level:	None
Resolved date:	22/Jun/09
Affected Branches:	MOODLE_19_STABLE
Fixed Branches:	MOODLE_20_STABLE

All

Comments

Change History

Version Control

Sort Order:

Petr Skoda made changes - 18/Jun/09 03:32 PM

Field	Original Value	New Value
Assignee	Petr Skoda [ skodak ]	moodle.com [ moodle.com ]

Nicolas Connault made changes - 19/Jun/09 02:39 PM

Assignee

moodle.com [ moodle.com ]

Nicolas Connault [ nicolasconnault ]

Nicolas Connault made changes - 19/Jun/09 02:40 PM

Status

Open [ 1 ]

In Progress [ 3 ]

[ Permalink | « Hide ]

Nicolas Connault added a comment - 19/Jun/09 02:40 PM

Attached a patch with ereg -> preg replacements. Please review

Nicolas Connault made changes - 19/Jun/09 02:40 PM

Attachment

MDL-19418.patch [ 17719 ]

Nicolas Connault committed 36 files to 'Moodle CVS' - 22/Jun/09 09:22 AM

~~MDL-19418~~ Replaced ereg* by preg*

MODIFY	auth/shibboleth/auth.php	Rev. 1.25	(+1 -1 lines)
MODIFY	mod/feedback/analysis_course.php	Rev. 1.11	(+3 -3 lines)
MODIFY	mnet/lib.php	Rev. 1.34	(+2 -2 lines)
MODIFY	mod/lesson/format.php	Rev. 1.15	(+3 -3 lines)
MODIFY	admin/mnet/MethodTable.php	Rev. 1.3	(+5 -5 lines)
MODIFY	question/format/qti_two/format.php	Rev. 1.10	(+3 -3 lines)
MODIFY	calendar/lib.php	Rev. 1.232	(+3 -3 lines)
MODIFY	search/documents/assignment_document.php	Rev. 1.6	(+2 -2 lines)
MODIFY	question/type/numerical/questiontype.php	Rev. 1.36	(+3 -3 lines)
MODIFY	login/index.php	Rev. 1.151	(+2 -2 lines)
MODIFY	question/type/calculated/questiontype.php	Rev. 1.63	(+14 -14 lines)
MODIFY	lib/simpletest/testweblib.php	Rev. 1.13	(+6 -0 lines)
MODIFY	enrol/authorize/enrol_form.php	Rev. 2.9	(+12 -12 lines)
MODIFY	mod/chat/chatd.php	Rev. 1.40	(+4 -4 lines)
MODIFY	question/type/calculated/edit_calculated_form.php	Rev. 1.25	(+3 -3 lines)
MODIFY	question/type/calculatedsimple/questiontype.php	Rev. 1.6	(+2 -2 lines)
MODIFY	mod/feedback/lib.php	Rev. 1.41	(+2 -2 lines)
MODIFY	lib/weblib.php	Rev. 1.1271	(+23 -10 lines)
MODIFY	pix/smartpix.php	Rev. 1.5	(+4 -4 lines)
MODIFY	question/format.php	Rev. 1.54	(+3 -3 lines)
MODIFY	question/type/multianswer/questiontype.php	Rev. 1.75	(+3 -3 lines)
MODIFY	question/format/blackboard_six/format.php	Rev. 1.5	(+1 -1 lines)
MODIFY	admin/uploaduser.php	Rev. 1.95	(+9 -9 lines)
MODIFY	mod/wiki/lib.php	Rev. 1.69	(+1 -1 lines)
MODIFY	user/editadvanced_form.php	Rev. 1.31	(+2 -2 lines)
MODIFY	login/signup_form.php	Rev. 1.43	(+3 -3 lines)
MODIFY	question/format/webct/format.php	Rev. 1.20	(+49 -50 lines)
MODIFY	lib/moodlelib.php	Rev. 1.1217	(+18 -18 lines)
MODIFY	question/type/calculatedsimple/edit_calculatedsimple_form.php	Rev. 1.5	(+4 -4 lines)
MODIFY	question/type/random/questiontype.php	Rev. 1.32	(+4 -4 lines)
MODIFY	question/format/xml/format.php	Rev. 1.55	(+2 -2 lines)
MODIFY	mod/scorm/player.php	Rev. 1.50	(+3 -3 lines)
MODIFY	install.php	Rev. 1.132	(+2 -2 lines)
MODIFY	question/format/gift/format.php	Rev. 1.33	(+6 -6 lines)
MODIFY	mod/scorm/datamodels/aicclib.php	Rev. 1.18	(+2 -2 lines)
MODIFY	mod/lesson/reformat.php	Rev. 1.7	(+3 -3 lines)

[ Permalink | « Hide ]

Nicolas Connault added a comment - 22/Jun/09 09:26 AM

The only ereg* functions left now are in third party libraries.

Nicolas Connault made changes - 22/Jun/09 09:26 AM

Status	In Progress [ 3 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

[ Permalink | « Hide ]

Pierre Pichet added a comment - 15/Aug/09 07:02 AM

There is a problem in calculated/questiontype.php
Warning: preg_match() [function.preg-match]: Unknown modifier '<' in C:\moodle\moodle\site\moodle_head\question\type\calculated\questiontype.php on line 1899

This 1899 line explore the math formula.
$safeoperatorchar = '-+/%>:^~<?=&|!'; / */
$operatorornumber = "[$safeoperatorchar.0-9eE]";

while (preg_match("_{(^|[$safeoperatorchar,(])([a-z0-9_]*)\\(($operatorornumber+(,$operatorornumber+((,$operatorornumber+)+)?)?)?
)}",
$formula, $regs)) {

pichetp committed 1 file to 'Moodle CVS' - 07/Sep/09 04:34 AM

~~MDL-19418~~ Correcting expression by escaping ~ so that it is interpreted as a charracter

MODIFY

question/type/calculated/questiontype.php

Rev. 1.67

(+2 -2 lines)

All content on this web site is made available under the GNU General Public License, unless otherwise stated.