Issue Details (XML | Word | Printable)

Key: MDL-19474
Type: Sub-task Sub-task
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Petr Skoda
Reporter: Petr Skoda
Votes: 0
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-14679

remove obsoleted adodb database drivers before 2.0 branching

Created: 12/Jun/09 07:12 PM   Updated: 09/Oct/09 04:25 PM
Return to search
Component/s: Database SQL/XMLDB
Affects Version/s: 2.0
Fix Version/s: 2.0

Participants: Eloy Lafuente (stronk7) and Petr Skoda
Security Level: None
QA Assignee: Eloy Lafuente (stronk7)
Resolved date: 09/Oct/09
Affected Branches: MOODLE_20_STABLE
Fixed Branches: MOODLE_20_STABLE


 Description  « Hide
After everything is fully tested and confirmed to be working fine ;-)
all native drivers except missing MSSQL should work better now

adding notes into source code now...

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Petr Skoda committed 10 files to 'Moodle CVS' - 13/Jun/09 05:11 PM
MDL-19474 adding TODO for removing of obsoleted adodb drivers before branching
MODIFY lib/dml/Attic/odbc_mssql_adodb_moodle_database.php   Rev. 1.6    (+2 -0 lines)
MODIFY lib/dml/Attic/mssql_adodb_moodle_database.php   Rev. 1.30    (+2 -0 lines)
MODIFY lib/dml/Attic/postgres7_adodb_moodle_database.php   Rev. 1.25    (+2 -0 lines)
MODIFY lib/dml/Attic/mysql_adodb_moodle_database.php   Rev. 1.6    (+2 -0 lines)
MODIFY lib/dml/Attic/mysqli_adodb_moodle_database.php   Rev. 1.18    (+2 -0 lines)
MODIFY lib/dml/Attic/adodb_moodle_recordset.php   Rev. 1.8    (+2 -0 lines)
MODIFY lib/dml/Attic/oci8po_adodb_moodle_database.php   Rev. 1.31    (+2 -0 lines)
MODIFY lib/dml/Attic/oci8po_adodb_moodle_recordset.php   Rev. 1.9    (+2 -0 lines)
MODIFY lib/dml/Attic/mssql_n_adodb_moodle_database.php   Rev. 1.6    (+2 -0 lines)
MODIFY lib/dml/Attic/adodb_moodle_database.php   Rev. 1.34    (+2 -0 lines)
[ Permalink | « Hide ]
Eloy Lafuente (stronk7) added a comment - 08/Oct/09 11:13 PM
I really think we are mature enough to accept it's time to drop these drivers once and for all.

So, reassigning to Petr, feeling he will enjoy resolving this bug.

+100

Ciao

PS: Some changes could be needed in setup (related with mysqli and adodb).


Eloy Lafuente (stronk7) made changes - 08/Oct/09 11:13 PM
Field Original Value New Value
Assignee Eloy Lafuente (stronk7) [ stronk7 ] Petr Skoda [ skodak ]
Eloy Lafuente (stronk7) made changes - 09/Oct/09 05:43 AM
QA Assignee stronk7
Petr Skoda made changes - 09/Oct/09 05:48 AM
Status Open [ 1 ] In Progress [ 3 ]
Petr Skoda committed 2 files to 'Moodle CVS' - 09/Oct/09 06:04 AM
MDL-19474 finally dropping support for old adodb moodle database drivers, yay!
MODIFY admin/report/unittest/dbtest.php   Rev. 1.13    (+3 -3 lines)
MODIFY admin/dbtransfer/database_transfer_form.php   Rev. 1.2    (+5 -8 lines)
Petr Skoda committed 1 file to 'Moodle CVS' - 09/Oct/09 06:25 AM
MDL-19474 finally dropping support for old adodb moodle database drivers, yay!
MODIFY lib/dmllib.php   Rev. 1.183    (+2 -20 lines)
Petr Skoda committed 16 files to 'Moodle CVS' - 09/Oct/09 06:34 AM
MDL-19474 One year and a half ago we started designing and implementing our new databse abstraction layer which included brand new moodle native drivers. Today we are finally removing old legacy drivers that were still using adodb internally. From now on the adodb will be used only in some authentication and enrolment plugins, we are probably going to drop adodb there too later in 2.x. Thanks everybody who helped test and improve our new drivers, even bigger thanks to all the great developers who created ADOdb!
MODIFY lib/dml/oci_native_moodle_database.php   Rev. 1.27    (+1 -1 lines)
DEL lib/dml/Attic/oci8po_adodb_moodle_recordset.php   Rev. 1.10    (+0 -0 lines)
MODIFY lib/dml/moodle_database.php   Rev. 1.103    (+1 -1 lines)
DEL lib/dml/Attic/mssql_n_adodb_moodle_database.php   Rev. 1.7    (+0 -0 lines)
DEL lib/dml/Attic/mysql_adodb_moodle_database.php   Rev. 1.7    (+0 -0 lines)
MODIFY lib/dml/mssql_native_moodle_database.php   Rev. 1.8    (+1 -1 lines)
DEL lib/dml/Attic/postgres7_adodb_moodle_database.php   Rev. 1.26    (+0 -0 lines)
DEL lib/dml/Attic/adodb_moodle_recordset.php   Rev. 1.9    (+0 -0 lines)
MODIFY lib/dml/pgsql_native_moodle_database.php   Rev. 1.38    (+1 -1 lines)
DEL lib/dml/Attic/oci8po_adodb_moodle_database.php   Rev. 1.32    (+0 -0 lines)
MODIFY lib/dml/mysqli_native_moodle_database.php   Rev. 1.44    (+1 -1 lines)
DEL lib/dml/Attic/adodb_moodle_database.php   Rev. 1.36    (+0 -0 lines)
MODIFY lib/dml/pdo_moodle_database.php   Rev. 1.21    (+1 -1 lines)
DEL lib/dml/Attic/odbc_mssql_adodb_moodle_database.php   Rev. 1.7    (+0 -0 lines)
DEL lib/dml/Attic/mysqli_adodb_moodle_database.php   Rev. 1.19    (+0 -0 lines)
DEL lib/dml/Attic/mssql_adodb_moodle_database.php   Rev. 1.34    (+0 -0 lines)
[ Permalink | « Hide ]
Petr Skoda added a comment - 09/Oct/09 06:35 AM
done, thanks a lot for you great work Eloy!

Petr Skoda made changes - 09/Oct/09 06:35 AM
Status In Progress [ 3 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
[ Permalink | « Hide ]
Eloy Lafuente (stronk7) added a comment - 09/Oct/09 04:25 PM
Bah, ty Petr!


Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators