|
[
Permalink
| « Hide
]
Anthony Borrow added a comment - 18/Jun/09 09:08 AM
Tim - Here is a quick and simple stab at this, it just adds an extra attempt to get the string and an additional place to check (questionformat). I'm going to downgrade this to trivial but hopefully this patch will make it painless. I don't want it to distract you from the work on Moodle 2.0 themes. Peace - Anthony
Downgrading to trivial. The work around is simple enough to add the string to the lang folder's quiz.php file but it would be nice to make question formats more modular. Peace - Anthony
I think we should first wait for MDL-16438. Can you do another patch once Petr has committed his work.
Also, we really need separate patches for 1.9 and HEAD. However, your patch is definitely along the right lines, and it would be great to get it committed. Thanks. Thanks Tim - once MDL-16438 is done then I will look and see what needs to happen in 2.0. I remembered that you had done some work refactoring get_string but I could not remember if that was for 1.9 or just for 2.0. I've linked the issues so we can see if it is still an issue for Moodle 2.0. In fact, if you want we could make this tracker issue specific to 1.9 and create another for 2.0 after we confirm it is still an issue. It could be that the new get_string and MDL-16438 work will resolve this issue for HEAD. Peace - Anthony
Tim - Good to know, so then we should probably use qformat_ instead of questionformat_ in the 1.9 patch. I do prefer questionformat_ for better readability. I wonder if qformat deviates a bit from the norm of using whole English words as mentioned in http://docs.moodle.org/en/Development:Coding_style#Naming_Conventions
 . The simple q could be interpreted as quiz, question, queue, query, etc. Peace - Anthony Well, switching qformat to questionformat could easily be handled with a quick vim search and replace but it is trivial and not something I feel strongly about so long as we don't start getting lazy and start abbreviating all over the place resulting in cryptic code. I just figured I would mention it to raise awareness. Peace - Anthony
this was fixed together with the rest of all other plugins types inMDL-16438
thanks for the report, please test and report any problems or regressions petr Thanks Petr - Since this is fixed in head, do you think it would be worth applying the patch I attached (changing questionformat_ to qformat_) for Moodle 1.9 only? It is a trivial issue but for those affected by it, it could be helpful. Alternatively they could apply the patch if they are so affected. We could just add a comment to the question format installation instructions or just have them continue to patch the /lang/en_utf8/quiz.php file. The workaround is simple enough that that those affected should be able to handle it without too much trouble. Peace - Anthony
Assigning back to Tim for consideration...
updated patch file (questionformat changed to qformat)
Tim - Sorry I didn't understand your question about: "does the bit of the patch that gets the name of the import format need to be applied to head?" Peace - Anthony
Tim - I think this is what you may have been referring to. Yes, in order for the things to work in HEAD we need this. I'll go ahead and commit. Peace - Anthony
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Bug
Resolved
Trivial
Question formats from contrib are not completely pluggable - must modify core lang files.
 |
|
All content on this web site is made available under the GNU General Public License, unless otherwise stated.
