
| Key: |
MDL-19560
|
| Type: |
Bug
|
| Status: |
Closed
|
| Resolution: |
Cannot Reproduce
|
| Priority: |
Blocker
|
| Assignee: |
Petr Skoda
|
| Reporter: |
Tang Wei
|
| Votes: |
1
|
| Watchers: |
1
|
|
|
|
Environment:
|
Linux, MySQL, Moodle 1.9.5
|
|
| Database: |
MySQL
|
| Participants: |
Dan Marsden, Petr Skoda and Tang Wei
|
| Security Level: |
None
|
| QA Assignee: |
Dan Marsden
|
| Resolved date: |
17/Aug/09
|
| Affected Branches: |
MOODLE_19_STABLE
|
| Fixed Branches: |
MOODLE_19_STABLE
|
|
Some moodle security codes in file.php:
if (!$forcedownload) {
require_once("$CFG->dirroot/mod/$mod/lib.php");
$trustedfunction = $mod.'_is_moddata_trusted';
if (function_exists($trustedfunction)) {
// force download of all attachments that are not trusted
$forcedownload = !$trustedfunction();
} else {
$forcedownload = 1;
}
}
Caused SCORM module always force user to download the scorm content instead of display it.
After check mod/scorm/lib.php, there was no "scorm_is_moddata_trusted" function. After add such function and make it always return true(trusted scorm data because it only can be uploaded by tutor/admin), it works.
|
|
Description
|
Some moodle security codes in file.php:
if (!$forcedownload) {
require_once("$CFG->dirroot/mod/$mod/lib.php");
$trustedfunction = $mod.'_is_moddata_trusted';
if (function_exists($trustedfunction)) {
// force download of all attachments that are not trusted
$forcedownload = !$trustedfunction();
} else {
$forcedownload = 1;
}
}
Caused SCORM module always force user to download the scorm content instead of display it.
After check mod/scorm/lib.php, there was no "scorm_is_moddata_trusted" function. After add such function and make it always return true(trusted scorm data because it only can be uploaded by tutor/admin), it works.
|
Show » |
made changes - 18/Jun/09 05:32 PM
| Field |
Original Value |
New Value |
|
Assignee
|
Dan Marsden
[ danmarsden
]
|
Petr Skoda
[ skodak
]
|
made changes - 18/Jun/09 05:32 PM
|
Summary
|
A forcedownload error caused SCORM mod not works.
|
Regression: A forcedownload error caused SCORM mod not works.
|
|
Priority
|
Minor
[ 4
]
|
Blocker
[ 1
]
|
made changes - 18/Jun/09 05:33 PM
|
Fix Version/s
|
|
1.9.6
[ 10340
]
|
made changes - 18/Jun/09 06:00 PM
|
Status
|
Open
[ 1
]
|
In Progress
[ 3
]
|
made changes - 17/Aug/09 03:54 PM
|
Resolution
|
|
Cannot Reproduce
[ 5
]
|
|
Status
|
In Progress
[ 3
]
|
Resolved
[ 5
]
|
made changes - 17/Aug/09 03:57 PM
|
QA Assignee
|
|
danmarsden
|
|
Status
|
Resolved
[ 5
]
|
Closed
[ 6
]
|
|
thanks!