Issue Details (XML | Word | Printable)

Key: MDL-19560
Type: Bug Bug
Status: Closed Closed
Resolution: Cannot Reproduce
Priority: Blocker Blocker
Assignee: Petr Skoda
Reporter: Tang Wei
Votes: 1
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Regression: A forcedownload error caused SCORM mod not works.

Created: 18/Jun/09 04:58 PM   Updated: 17/Aug/09 03:57 PM
Return to search
Component/s: SCORM
Affects Version/s: 1.9.5
Fix Version/s: 1.9.6

Environment: Linux, MySQL, Moodle 1.9.5

Database: MySQL
Participants: Dan Marsden, Petr Skoda and Tang Wei
Security Level: None
QA Assignee: Dan Marsden
Resolved date: 17/Aug/09
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE


 Description  « Hide
Some moodle security codes in file.php:

 if (!$forcedownload) {
                require_once("$CFG->dirroot/mod/$mod/lib.php");
                $trustedfunction = $mod.'_is_moddata_trusted';
                if (function_exists($trustedfunction)) {
                    // force download of all attachments that are not trusted
                    $forcedownload = !$trustedfunction();
                } else {
                    $forcedownload = 1;
                }
            }

Caused SCORM module always force user to download the scorm content instead of display it.

After check mod/scorm/lib.php, there was no "scorm_is_moddata_trusted" function. After add such function and make it always return true(trusted scorm data because it only can be uploaded by tutor/admin), it works.




 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
No commits have yet been performed on this issue.