Moodle

cleanup filepicker code to require css and js before printing head

Details

  • Type: Sub-task Sub-task
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 2.0
  • Fix Version/s: STABLE backlog
  • Component/s: HTML Editor
  • Labels:
    None
  • Affected Branches:
    MOODLE_20_STABLE

Description

The filepicker integration is not strict and I suppose it was the reason why $PAGE->requires->yui() di not process required styles

attaching patch, please review...

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Petr Škoda (skodak) added a comment -

Tim: could you please review my patch? I would like to get it into cvs soon, thanks a lot...

Show
Petr Škoda (skodak) added a comment - Tim: could you please review my patch? I would like to get it into cvs soon, thanks a lot...
Hide
Permalink
Tim Hunt added a comment -

Looks OK to me on a brief inspection. The general thrust of the patch seems to be in the right direction. However, I'm adding Dongsheng, becuase he is the real expert here.

Show
Tim Hunt added a comment - Looks OK to me on a brief inspection. The general thrust of the patch seems to be in the right direction. However, I'm adding Dongsheng, becuase he is the real expert here.
Hide
Permalink
Dongsheng Cai added a comment -

+1 for Petr's patch, just one thing, can we move css style in moodle theme files?

Show
Dongsheng Cai added a comment - +1 for Petr's patch, just one thing, can we move css style in moodle theme files?
Hide
Permalink
Petr Škoda (skodak) added a comment -

I discovered some more problems while trying to sleep yesterday, going to work on this more today, thanks...

Show
Petr Škoda (skodak) added a comment - I discovered some more problems while trying to sleep yesterday, going to work on this more today, thanks...

People

Vote (0)
Watch (3)

Dates

  • Created:
    Updated:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.