[#MDL-19580] cleanup filepicker code to require css and js before printing head

Issue Details (XML | Word | Printable)

Key:	MDL-19580
Type:	Sub-task
Status:	Open
Priority:	Major
Assignee:	Petr Skoda
Reporter:	Petr Skoda
Votes:	0
Watchers:	3

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

MDL-16583

cleanup filepicker code to require css and js before printing head

Created: 22/Jun/09 02:43 AM Updated: 22/Jun/09 03:10 PM

Return to search

Component/s:

HTML Editor

Affects Version/s:

2.0

Fix Version/s:

2.0

File Attachments:

yui_filepicker_cleanup_patch.patch (21 kB)

Participants:	Dongsheng Cai, Petr Skoda and Tim Hunt
Security Level:	None
Affected Branches:	MOODLE_20_STABLE
Fixed Branches:	MOODLE_20_STABLE

Description

« Hide

The filepicker integration is not strict and I suppose it was the reason why $PAGE->requires->yui() di not process required styles

attaching patch, please review...

All

Comments

Change History

Version Control

Sort Order:

[ Permalink | « Hide ]

Petr Skoda added a comment - 22/Jun/09 02:46 AM

Tim: could you please review my patch? I would like to get it into cvs soon, thanks a lot...

[ Permalink | « Hide ]

Tim Hunt added a comment - 22/Jun/09 01:40 PM

Looks OK to me on a brief inspection. The general thrust of the patch seems to be in the right direction. However, I'm adding Dongsheng, becuase he is the real expert here.

[ Permalink | « Hide ]

Dongsheng Cai added a comment - 22/Jun/09 01:58 PM

+1 for Petr's patch, just one thing, can we move css style in moodle theme files?

[ Permalink | « Hide ]

Petr Skoda added a comment - 22/Jun/09 03:10 PM

I discovered some more problems while trying to sleep yesterday, going to work on this more today, thanks...

All content on this web site is made available under the GNU General Public License, unless otherwise stated.