[#MDL-19580] cleanup filepicker code to require css and js before printing head

Issue Details (XML | Word | Printable)

Key:	MDL-19580
Type:	Sub-task
Status:	Open
Priority:	Major
Assignee:	Petr Skoda
Reporter:	Petr Skoda
Votes:	0
Watchers:	3

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

MDL-16583

cleanup filepicker code to require css and js before printing head

Created: 22/Jun/09 02:43 AM Updated: 22/Jun/09 03:10 PM

Component/s:

HTML Editor

Affects Version/s:

2.0

Fix Version/s:

2.0

File Attachments:

yui_filepicker_cleanup_patch.patch (21 kB)

Participants:	Dongsheng Cai, Petr Skoda and Tim Hunt
Security Level:	None
Affected Branches:	MOODLE_20_STABLE
Fixed Branches:	MOODLE_20_STABLE

Description

« Hide

The filepicker integration is not strict and I suppose it was the reason why $PAGE->requires->yui() di not process required styles

attaching patch, please review...

All

Comments

Change History

Version Control

Sort Order:

Petr Skoda committed 1 file to 'Moodle CVS' - 22/Jun/09 02:45 AM

MDL-19580 preparation for requiring yui before print_header()

MODIFY

admin/user.php

Rev. 1.123

(+14 -11 lines)

Petr Skoda committed 14 files to 'Moodle CVS' - 25/Jun/09 06:34 AM

MDL-19580 cleanup of require css and js filepicker code

ADD	repository/repository.css	Rev. 1.1	(+0 -0 lines)
MODIFY	repository/lib.php	Rev. 1.182	(+30 -105 lines)
MODIFY	lib/Attic/javascript.php	Rev. 1.52	(+0 -2 lines)
MODIFY	lib/form/filepicker.php	Rev. 1.29	(+6 -3 lines)
MODIFY	lib/weblib.php	Rev. 1.1276	(+1 -0 lines)
MODIFY	lib/adminlib.php	Rev. 1.367	(+2 -0 lines)
MODIFY	lib/form/htmleditor.php	Rev. 1.18	(+2 -0 lines)
MODIFY	repository/repository.src.js	Rev. 1.11	(+3 -2 lines)
MODIFY	lib/editorlib.php	Rev. 1.16	(+31 -0 lines)
MODIFY	mod/resource/type/file/Attic/resource.class.php	Rev. 1.101	(+3 -3 lines)
MODIFY	lib/form/filemanager.php	Rev. 1.23	(+6 -4 lines)
MODIFY	lib/editor/tinymce/lib.php	Rev. 1.6	(+6 -2 lines)
MODIFY	lib/ajax/ajaxlib.php	Rev. 1.62	(+3 -1 lines)
MODIFY	lib/form/editor.php	Rev. 1.16	(+7 -3 lines)

All content on this web site is made available under the GNU General Public License, unless otherwise stated.