Issue Details (XML | Word | Printable)

Key: MDL-19598
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Sam Marshall
Reporter: Sam Marshall
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Access: Should not print skip link for block with no title

Created: 23/Jun/09 12:54 AM   Updated: 30/Jun/09 05:37 PM
Return to search
Component/s: Accessibility
Affects Version/s: 1.9.5
Fix Version/s: 1.9.6

Participants: Helen Foster and Sam Marshall
Security Level: None
QA Assignee: Helen Foster
Resolved date: 23/Jun/09
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE


 Description  « Hide
When blocks have no title, there is code that is supposed to stop it printing out the skip link (as it does not make sense to have a skip link that offers to 'Skip [blank]' - how is the user supposed to know what they are skipping).

Unfortunately this code is broken. I am going to fix it.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Sam Marshall added a comment - 23/Jun/09 01:12 AM
Fixed in 1.9 and HEAD.

Basically the logic was broken because it was testing if(!empty($heading)), but $heading is something like <h2></h2> when it's empty, so this wasn't right - should have used $title instead. It was already using $title for the actual text within the skip link.


Helen Foster added a comment - 30/Jun/09 05:37 PM
Sam, thanks for reporting and fixing this issue.

Tested in 1.9.5+ by creating an html block with no title then examining the source code.

(Amending the fix version to 1.9.6 only, as HEAD should not be included unless it's the only version.)