|
|
| Participants: |
Helen Foster and Sam Marshall
|
| Security Level: |
None
|
| QA Assignee: |
Helen Foster
|
| Resolved date: |
23/Jun/09
|
| Affected Branches: |
MOODLE_19_STABLE
|
| Fixed Branches: |
MOODLE_19_STABLE
|
|
When blocks have no title, there is code that is supposed to stop it printing out the skip link (as it does not make sense to have a skip link that offers to 'Skip [blank]' - how is the user supposed to know what they are skipping).
Unfortunately this code is broken. I am going to fix it.
|
|
Description
|
When blocks have no title, there is code that is supposed to stop it printing out the skip link (as it does not make sense to have a skip link that offers to 'Skip [blank]' - how is the user supposed to know what they are skipping).
Unfortunately this code is broken. I am going to fix it. |
Show » |
sam_marshall committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 23/Jun/09 01:08 AM
MDL-19598: Error in logic that should hide 'skip link' when block doesn't have title
|
|
|
sam_marshall committed 1 file to 'Moodle CVS' - 23/Jun/09 01:09 AM
MDL-19598: Error in logic that should hide 'skip link' when block doesn't have title
|
|
|
made changes - 23/Jun/09 01:12 AM
| Field |
Original Value |
New Value |
|
Status
|
Open
[ 1
]
|
Resolved
[ 5
]
|
|
Resolution
|
|
Fixed
[ 1
]
|
made changes - 30/Jun/09 05:37 PM
|
Fix Version/s
|
2.0
[ 10122
]
|
|
|
Status
|
Resolved
[ 5
]
|
Closed
[ 6
]
|
|
QA Assignee
|
|
tsala
|
|
Bug
Closed
Minor
Access: Should not print skip link for block with no title
Basically the logic was broken because it was testing if(!empty($heading)), but $heading is something like <h2></h2> when it's empty, so this wasn't right - should have used $title instead. It was already using $title for the actual text within the skip link.