Moodle

We shoudl encapsulate $CFG->rolesactive in a function

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 2.0
  • Component/s: Libraries
  • Labels:
    None
  • Affected Branches:
    MOODLE_20_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

The fact that empty($CFG->rolesactive) is the right way to find out whethet Moodle is fully installed is somewhat obscure.

I think it makes code easier to follow if we create a during_initial_install() function.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Tim Hunt added a comment -

Petr, are you happy for this patch to go in?

(This all started because I noticed that user_login_string uses a different way to check this. I'll fix that in a minutes.)

Show
Tim Hunt added a comment - Petr, are you happy for this patch to go in? (This all started because I noticed that user_login_string uses a different way to check this. I'll fix that in a minutes.)
Hide
Permalink
Petr Škoda (skodak) added a comment -

+1, makes sense to me

Show
Petr Škoda (skodak) added a comment - +1, makes sense to me
Hide
Permalink
Tim Hunt added a comment -

Thanks Petr.

Show
Tim Hunt added a comment - Thanks Petr.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.