| Key: |
MDL-19610
|
| Type: |
Improvement
|
| Status: |
Resolved
|
| Resolution: |
Fixed
|
| Priority: |
Minor
|
| Assignee: |
Tim Hunt
|
| Reporter: |
Tim Hunt
|
| Votes: |
0
|
| Watchers: |
1
|
|
|
| Participants: |
Petr Skoda and Tim Hunt
|
| Security Level: |
None
|
| Resolved date: |
24/Jun/09
|
| Affected Branches: |
MOODLE_20_STABLE
|
| Fixed Branches: |
MOODLE_20_STABLE
|
|
The fact that empty($CFG->rolesactive) is the right way to find out whethet Moodle is fully installed is somewhat obscure.
I think it makes code easier to follow if we create a during_initial_install() function.
|
|
Description
|
The fact that empty($CFG->rolesactive) is the right way to find out whethet Moodle is fully installed is somewhat obscure.
I think it makes code easier to follow if we create a during_initial_install() function. |
Show » |
tjhunt committed 8 files to 'Moodle CVS' - 24/Jun/09 05:17 PM
install: MDL-19610 encapsulate empty($CFG->rolesactive) checks in a during_initial_install() function.
|
|
|
made changes - 24/Jun/09 05:18 PM
|
Status
|
Open
[ 1
]
|
Resolved
[ 5
]
|
|
Fix Version/s
|
|
2.0
[ 10122
]
|
|
Resolution
|
|
Fixed
[ 1
]
|
|
We shoudl encapsulate $CFG->rolesactive in a function
(This all started because I noticed that user_login_string uses a different way to check this. I'll fix that in a minutes.)