Issue Details (XML | Word | Printable)

Key: MDL-19610
Type: Improvement Improvement
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Tim Hunt
Reporter: Tim Hunt
Votes: 0
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

We shoudl encapsulate $CFG->rolesactive in a function

Created: 24/Jun/09 01:48 PM   Updated: 24/Jun/09 05:18 PM
Return to search
Component/s: Lib
Affects Version/s: 2.0
Fix Version/s: 2.0

File Attachments: 1. Text File during_initial_install.patch (9 kB)


Participants: Petr Skoda and Tim Hunt
Security Level: None
Resolved date: 24/Jun/09
Affected Branches: MOODLE_20_STABLE
Fixed Branches: MOODLE_20_STABLE


 Description  « Hide
The fact that empty($CFG->rolesactive) is the right way to find out whethet Moodle is fully installed is somewhat obscure.

I think it makes code easier to follow if we create a during_initial_install() function.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
tjhunt committed 8 files to 'Moodle CVS' - 24/Jun/09 05:17 PM
install: MDL-19610 encapsulate empty($CFG->rolesactive) checks in a during_initial_install() function.
MODIFY admin/settings/users.php   Rev. 1.51    (+4 -4 lines)
MODIFY lib/weblib.php   Rev. 1.1275    (+3 -3 lines)
MODIFY admin/index.php   Rev. 1.390    (+4 -3 lines)
MODIFY lib/accesslib.php   Rev. 1.602    (+3 -3 lines)
MODIFY lib/setuplib.php   Rev. 1.60    (+15 -0 lines)
MODIFY lib/pagelib.php   Rev. 1.123    (+1 -1 lines)
MODIFY mnet/environment.php   Rev. 1.22    (+2 -2 lines)
MODIFY lib/adminlib.php   Rev. 1.366    (+3 -3 lines)