[#MDL-19611] Restore buttons that were lost in the tinymce upgrade

Issue Details (XML | Word | Printable)

Key:	MDL-19611
Type:	Sub-task
Status:	Open
Priority:	Critical
Assignee:	Petr Skoda
Reporter:	Martin Dougiamas
Votes:	0
Watchers:	0

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

MDL-19211

Restore buttons that were lost in the tinymce upgrade

Created: 24/Jun/09 04:32 PM Updated: 22/Aug/09 02:09 AM

Return to search

Component/s:

HTML Editor

Affects Version/s:

2.0

Fix Version/s:

2.0

Issue Links:

Blockers

This issue blocks:

MDL-20139 Remove extra TinyMCE buttons

Participants:	Martin Dougiamas, Olli Savolainen and Petr Skoda
Security Level:	None
Affected Branches:	MOODLE_20_STABLE
Fixed Branches:	MOODLE_20_STABLE

Description

« Hide

In the last upgrade of TinyMCE the video button has gone. I discovered this during a demo to the french Moot . Doh!

Instead, there a bunch of quite useless buttons like "insert date" and "insert time", as well as layers ...

The whole selection of buttons needs to be looked at. I'd prefer to see just two rows (three is too much).

All

Comments

Change History

Version Control

Sort Order:

[ Permalink | « Hide ]

Petr Skoda added a comment - 24/Jun/09 04:57 PM

Yes, in case of video/applets/flash and other non-safe items we need to take trusttext and noclean option into account. Sorry for the trouble...

[ Permalink | « Hide ]

Martin Dougiamas added a comment - 25/Jun/09 11:32 AM

But the Youtube videos were just inserting a link ...

So what's your plan with this? I feel a bit like we're going backwards here ...

[ Permalink | « Hide ]

Petr Skoda added a comment - 25/Jun/09 03:02 PM

The plan is pretty simple, allow only those editor UI elements that produce code that passes through text cleaning.I already added the noclean and truested option to editor embedding code. We will have to further modify the tinymce plugin to fully solve this issue.

[ Permalink | « Hide ]

Petr Skoda added a comment - 25/Jun/09 03:05 PM

I suppose we could duplicate the media plugin and create new safemedia plugin which accepts only links, it could also inform about the currently enabled multimedia text filters.

[ Permalink | « Hide ]

Olli Savolainen added a comment - 22/Aug/09 02:09 AM

This is not exactly duplicate due to the discussion....

All content on this web site is made available under the GNU General Public License, unless otherwise stated.