Moodle

Restore buttons that were lost in the tinymce upgrade

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 2.0
  • Component/s: HTML Editor
  • Labels:
    None
  • Affected Branches:
    MOODLE_20_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

In the last upgrade of TinyMCE the video button has gone. I discovered this during a demo to the french Moot . Doh!

Instead, there a bunch of quite useless buttons like "insert date" and "insert time", as well as layers ...

The whole selection of buttons needs to be looked at. I'd prefer to see just two rows (three is too much).

Issue Links

This issue blocks:
MDL-20139 Remove extra TinyMCE buttons Minor Open
This issue is blocked by:
MDL-20139 Remove extra TinyMCE buttons Minor Open

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Petr Škoda (skodak) added a comment -

Yes, in case of video/applets/flash and other non-safe items we need to take trusttext and noclean option into account. Sorry for the trouble...

Show
Petr Škoda (skodak) added a comment - Yes, in case of video/applets/flash and other non-safe items we need to take trusttext and noclean option into account. Sorry for the trouble...
Hide
Permalink
Martin Dougiamas added a comment -

But the Youtube videos were just inserting a link ...

So what's your plan with this? I feel a bit like we're going backwards here ...

Show
Martin Dougiamas added a comment - But the Youtube videos were just inserting a link ... So what's your plan with this? I feel a bit like we're going backwards here ...
Hide
Permalink
Petr Škoda (skodak) added a comment -

The plan is pretty simple, allow only those editor UI elements that produce code that passes through text cleaning.I already added the noclean and truested option to editor embedding code. We will have to further modify the tinymce plugin to fully solve this issue.

Show
Petr Škoda (skodak) added a comment - The plan is pretty simple, allow only those editor UI elements that produce code that passes through text cleaning.I already added the noclean and truested option to editor embedding code. We will have to further modify the tinymce plugin to fully solve this issue.
Hide
Permalink
Petr Škoda (skodak) added a comment -

I suppose we could duplicate the media plugin and create new safemedia plugin which accepts only links, it could also inform about the currently enabled multimedia text filters.

Show
Petr Škoda (skodak) added a comment - I suppose we could duplicate the media plugin and create new safemedia plugin which accepts only links, it could also inform about the currently enabled multimedia text filters.
Hide
Permalink
Olli Savolainen added a comment -

This is not exactly duplicate due to the discussion....

Show
Olli Savolainen added a comment - This is not exactly duplicate due to the discussion....
Hide
Permalink
Olli Savolainen added a comment -

Sorry for the messy linkage, I believe MDL-20139 solves this one completely. Just added a new patch there.

Show
Olli Savolainen added a comment - Sorry for the messy linkage, I believe MDL-20139 solves this one completely. Just added a new patch there.
Hide
Permalink
Petr Škoda (skodak) added a comment -

the video button is back, closing for now, please file a separate issues if necessary, thanks!

Show
Petr Škoda (skodak) added a comment - the video button is back, closing for now, please file a separate issues if necessary, thanks!

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.