[#MDL-19648] We need more tests on the output of dml functions to ensure they are consistent across db engines - Moodle Tracker

Details

Type: Bug
Status: Open
Priority: Minor
Resolution: Unresolved
Affects Version/s: 2.0
Fix Version/s: None
Component/s: Unit tests
Labels:
None

Affected Branches:
MOODLE_20_STABLE

Description

For things like column naming

More Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

tests.patch

28/Jun/09 10:57 PM

2 kB

Dan Poltawski

Activity

Hide

Permalink

Dan Poltawski added a comment - 28/Jun/09 10:57 PM

Adding Eloy and Petr here.

When playing with sqlite - I noticed that none of the current dml tests didn't spot inconsistencies with complicated things like subqueries.

In the case of sqlite it was returning things like:

stdClass Object
(
[one.name] => record3
[one.course] => 3
)

Instead of:

stdClass Object
(
[name] => record3
[course] => 3
)

Attached one test which demonstrates this (but we probably need more and I am not sure if its the best approach)

Show

Dan Poltawski added a comment - 28/Jun/09 10:57 PM Adding Eloy and Petr here. When playing with sqlite - I noticed that none of the current dml tests didn't spot inconsistencies with complicated things like subqueries. In the case of sqlite it was returning things like: stdClass Object ( [one.name] => record3 [one.course] => 3 ) Instead of: stdClass Object ( [name] => record3 [course] => 3 ) Attached one test which demonstrates this (but we probably need more and I am not sure if its the best approach)

People

Assignee:

moodle.com

Reporter:

Dan Poltawski

Participants:

Dan Poltawski, moodle.com

Vote (0)

Watch (2)

Dates

Created:

28/Jun/09 10:46 PM

Updated:

13/Nov/09 4:08 PM