Issue Details (XML | Word | Printable)

Key: MDL-19674
Type: Bug Bug
Status: Open Open
Priority: Critical Critical
Assignee: Petr Škoda (skodak)
Reporter: Tim Hunt
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

We cannot refer to $CFG->pixpath in mod/glossary/settings.php

Created: 01/Jul/09 12:11 PM   Updated: 01/Jul/09 04:10 PM
Component/s: Glossary
Affects Version/s: 2.0
Fix Version/s: 2.0

Participants: Petr Škoda (skodak) and Tim Hunt
Security Level: None
Affected Branches: MOODLE_20_STABLE
Fixed Branches: MOODLE_20_STABLE


 Description  « Hide
mod/glossary/settings.php abuses admin_setting_heading to put some icons on the settings screen.

That is pretty evil already. However, what makes it really, really wicked is that to do this, it refers to $CFG->pixpath. That means that we refer to $CFG->pixpath in admin_get_root. However, in several places we need to call admin_get_root to get the admin tree before we have initialised all the information about the current theme.

I think that this should be a custom admin_setting class, so we only create the HTML on output.

(Assigning to Petr, since he originally wrote this code. However, it is not really his fault.)



 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Petr Škoda (skodak) added a comment - 01/Jul/09 03:24 PM
I guess we can simply remove those icons from admin settings :-D

Petr Škoda (skodak) added a comment - 01/Jul/09 04:10 PM
I have committed an ugly hack that hardcoded the pixpath for now, going to work on new setting after I finish resource migration