[#MDL-19693] The way the SCORM module uses $scormpixdir is not compatible with $OUTPUT->mod_pix_url

Issue Details (XML | Word | Printable)

Key:	MDL-19693
Type:	Sub-task
Status:	Resolved
Resolution:	Fixed
Priority:	Minor
Assignee:	Tim Hunt
Reporter:	Tim Hunt
Votes:	0
Watchers:	0

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

MDL-19077

The way the SCORM module uses $scormpixdir is not compatible with $OUTPUT->mod_pix_url

Created: 02/Jul/09 08:23 PM Updated: 04/Jul/09 12:15 PM

Return to search

Component/s:

SCORM

Affects Version/s:

2.0

Fix Version/s:

2.0

Participants:	Dan Marsden and Tim Hunt
Security Level:	None
Resolved date:	03/Jul/09
Affected Branches:	MOODLE_20_STABLE
Fixed Branches:	MOODLE_20_STABLE

Description

« Hide

I don't know if you have been following ~~MDL-19690~~ / http://moodle.org/mod/forum/discuss.php?d=126887

Anyway, the SCORM code needs to be changed, and since there is not an easy fix, I cannot do it now.

Just filing a bug so we don't forget about this. Needs to be dealt with before the release.

All

Comments

Change History

Version Control

Sort Order:

tjhunt committed 20 files to 'Moodle CVS' - 03/Jul/09 03:55 PM

~~MDL-19690~~ - the last lot of $CFG->pixpath to $OUTPUT->old_icon_url
Including ~~MDL-19693~~

RIP $CFG->pixpath

MODIFY	mod/wiki/ewiki/plugins/moodle/downloads.php	Rev. 1.20	(+5 -5 lines)
MODIFY	mod/forum/rate_ajax.js	Rev. 1.5	(+5 -12 lines)
MODIFY	mod/scorm/datamodels/scorm_datamodels.js	Rev. 1.2	(+2 -2 lines)
MODIFY	mod/scorm/datamodels/scorm_12lib.php	Rev. 1.22	(+12 -11 lines)
MODIFY	mod/quiz/styles.php	Rev. 1.25	(+1 -1 lines)
MODIFY	mod/resource/type/directory/Attic/resource.class.php	Rev. 1.46	(+7 -7 lines)
MODIFY	mod/quiz/locallib.php	Rev. 1.180	(+3 -3 lines)
MODIFY	mod/glossary/lib.php	Rev. 1.254	(+3 -3 lines)
MODIFY	mod/assignment/type/upload/assignment.class.php	Rev. 1.69	(+8 -8 lines)
MODIFY	mod/scorm/lib.php	Rev. 1.121	(+5 -6 lines)
MODIFY	mod/data/field/file/field.class.php	Rev. 1.33	(+6 -6 lines)
MODIFY	mod/scorm/datamodels/aicclib.php	Rev. 1.21	(+12 -11 lines)
MODIFY	mod/scorm/datamodels/scorm_13lib.php	Rev. 1.20	(+12 -11 lines)
MODIFY	mod/scorm/loadSCO.php	Rev. 1.53	(+2 -4 lines)
MODIFY	mod/assignment/type/uploadsingle/assignment.class.php	Rev. 1.45	(+4 -4 lines)
MODIFY	mod/forum/lib.php	Rev. 1.801	(+5 -6 lines)
MODIFY	mod/scorm/report.php	Rev. 1.63	(+3 -5 lines)
MODIFY	mod/assignment/lib.php	Rev. 1.392	(+3 -3 lines)
MODIFY	lib/outputlib.php	Rev. 1.18	(+3 -2 lines)
MODIFY	lib/pagelib.php	Rev. 1.133	(+2 -2 lines)

All content on this web site is made available under the GNU General Public License, unless otherwise stated.