Moodle

Can't hide course total without hiding all grade items

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.9.5
  • Fix Version/s: 2.0
  • Component/s: Gradebook
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

From discussion: http://moodle.org/mod/forum/discuss.php?d=127258

We have several courses where the teacher does not want to display the course total in the gradebook (because not all assessment is within Moodle).
Pre-1.9.5 we were able to hide the course total and the students could see their grades with no tally at the bottom of their User report.
Now when we hide the course total all grades appear to be hidden. Is there a way around this? We would like the behaviour to remain as it was in 1.9.4 where hiding the category didn't hide the items within it. Just to clarify the User Report does shows fine when we do NOT hide the course total - only we don't wanna do that!!

Cheers
Teresa

Attachments

  1. Text File
    grade_category.patch.txt
    07/Jan/10 4:07 PM
    2 kB
    Andrew Davis
  2. Text File
    grade_item.patch.txt
    07/Jan/10 4:07 PM
    2 kB
    Andrew Davis
  3. Text File
    grade_object.patch.txt
    07/Jan/10 4:07 PM
    2 kB
    Andrew Davis
  4. Text File
    upgrade.patch.txt
    07/Jan/10 4:10 PM
    0.9 kB
    Andrew Davis
  1. hiddenCourseTotal.gif
    90 kB
    03/Jul/09 5:58 AM

Issue Links

This issue duplicates:
MDL-19178 User grade report is not visible Major Closed
This issue is duplicated by:
MDL-11837 Add option to conditionally aggregate hidden grades Major Reopened
MDL-19132 separate category hiding from grade item hidden flag Major Closed
This issue has been marked as being related by:
MDL-21218 Hidden activity in Gradebook causes course grade to disappear from student Overview Report Minor Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Yolanda Ordoñez Rufat added a comment -

We find a workaround to this.
In "Grades" > "Categories and items" you edit the course parent category and set the parameter "Hidden until" to a future date (make sure it's set after the course end) instead of "hidden".
In "Grades" > "Settings" > "Course" make sure the parameter "Show hidden items" is set to "Only hidden until"
Now you need to show/hide each item as you need.

I hope this to be useful.

Show
Yolanda Ordoñez Rufat added a comment - We find a workaround to this. In "Grades" > "Categories and items" you edit the course parent category and set the parameter "Hidden until" to a future date (make sure it's set after the course end) instead of "hidden". In "Grades" > "Settings" > "Course" make sure the parameter "Show hidden items" is set to "Only hidden until" Now you need to show/hide each item as you need. I hope this to be useful.
Hide
Permalink
Martin Dougiamas added a comment -

I think we definitely need a new setting to independently set whether the total is shown to students in the user report and the overview report.

Something like:

  • Yes, always show the course total
  • No, never show the course total
  • Only show the total if there are no hidden items (default) <-- current behaviour

The setting should have a site default and be changeable on the course level as well.

Show
Martin Dougiamas added a comment - I think we definitely need a new setting to independently set whether the total is shown to students in the user report and the overview report. Something like:
  • Yes, always show the course total
  • No, never show the course total
  • Only show the total if there are no hidden items (default) <-- current behaviour
The setting should have a site default and be changeable on the course level as well.
Hide
Permalink
Andrew Davis added a comment -

Maybe add a fourth possibility: Show the course total excluding hidden items. That would allow you to show the current total of non-hidden items.

Show
Andrew Davis added a comment - Maybe add a fourth possibility: Show the course total excluding hidden items. That would allow you to show the current total of non-hidden items.
Hide
Permalink
Martin Dougiamas added a comment -

+1 for that, Andrew. Any feedback from any of the watchers here?

Show
Martin Dougiamas added a comment - +1 for that, Andrew. Any feedback from any of the watchers here?
Hide
Permalink
Helen Foster added a comment -

Sorry I don't understand why a new setting is needed. Isn't it sufficient to be able to hide the course total using the hide/show eye opposite the course total on the edit categories and items page?

Show
Helen Foster added a comment - Sorry I don't understand why a new setting is needed. Isn't it sufficient to be able to hide the course total using the hide/show eye opposite the course total on the edit categories and items page?
Hide
Permalink
Andrew Davis added a comment -

Still trying to figure out how this should work. We're trying to come up with a unified idea of how this should work that resolves this issue and MDL-21218.

Does the following sound correct?

If the course total is marked as hidden on the edit categories and items page (using the show/hide eye icon) it should be hidden from students on the overview and user report. All non-hidden items should still display (ie just the course total itself is hidden).

If the course total is NOT marked as hidden and it contains NO hidden items then the course title and all items should display on the overview and user report.

If the course total is NOT marked as hidden but the course contains one or more hidden items currently the user report always shows the course total and the overview report never shows the course total. I think we should use a new setting on both the user and overview reports to choose what to do when there are hidden items. Either hide the course total or to output a course total minus marks from the hidden items.

We can stick with the existing show/hide eye icon to hide the totals and add a setting to the user and overview reports specifying how to behave when there are hidden items.

Show
Andrew Davis added a comment - Still trying to figure out how this should work. We're trying to come up with a unified idea of how this should work that resolves this issue and MDL-21218. Does the following sound correct? If the course total is marked as hidden on the edit categories and items page (using the show/hide eye icon) it should be hidden from students on the overview and user report. All non-hidden items should still display (ie just the course total itself is hidden). If the course total is NOT marked as hidden and it contains NO hidden items then the course title and all items should display on the overview and user report. If the course total is NOT marked as hidden but the course contains one or more hidden items currently the user report always shows the course total and the overview report never shows the course total. I think we should use a new setting on both the user and overview reports to choose what to do when there are hidden items. Either hide the course total or to output a course total minus marks from the hidden items. We can stick with the existing show/hide eye icon to hide the totals and add a setting to the user and overview reports specifying how to behave when there are hidden items.
Hide
Permalink
Elena Ivanova added a comment -

This affects not only the Course total but all Category totals (unless there were some changes to the code)
If one hides Total for a sub-category, all grades in that whole category become hidden.

I agree with Helen - we do not really need extra controls
(even though we locally had to develop such extra controls as a quick fix - In the Settings tab we have 2 dropdowns "Show Course Total: Hide/Show" for both User and Overview reports)

I think that we need to fix the behavior of the Hide icon. So it will hide only the Total columns (for Course and for Categories), not other grade items inside.

Show
Elena Ivanova added a comment - This affects not only the Course total but all Category totals (unless there were some changes to the code) If one hides Total for a sub-category, all grades in that whole category become hidden. I agree with Helen - we do not really need extra controls (even though we locally had to develop such extra controls as a quick fix - In the Settings tab we have 2 dropdowns "Show Course Total: Hide/Show" for both User and Overview reports) I think that we need to fix the behavior of the Hide icon. So it will hide only the Total columns (for Course and for Categories), not other grade items inside.
Hide
Permalink
Elena Ivanova added a comment -

p.s I really like the idea of including/excluding hidden items from aggregation of category/course totals.

Show
Elena Ivanova added a comment - p.s I really like the idea of including/excluding hidden items from aggregation of category/course totals.
Hide
Permalink
Andrew Davis added a comment -

Patches containing a possible fix attached. This just allows the hiding of the course total without hiding everything else. Don't apply this to your server(s) until this has been reviewed

Show
Andrew Davis added a comment - Patches containing a possible fix attached. This just allows the hiding of the course total without hiding everything else. Don't apply this to your server(s) until this has been reviewed
Hide
Permalink
Andrew Davis added a comment -

Another patch containing the upgrade code that adds the new column required by the patches I just attached.

Ill deal with hidden items (including the discussion of associated new settings) in MDL-21218 where it probably should have always been

Show
Andrew Davis added a comment - Another patch containing the upgrade code that adds the new column required by the patches I just attached. Ill deal with hidden items (including the discussion of associated new settings) in MDL-21218 where it probably should have always been
Hide
Permalink
Elena Ivanova added a comment -

Andrew, this patch will help only with Course Total, correct? Not with Categories totals?

Show
Elena Ivanova added a comment - Andrew, this patch will help only with Course Total, correct? Not with Categories totals?
Hide
Permalink
Andrew Davis added a comment -

It should allow the course total to be hidden independent of items in the course AND allow category totals to be hidden independent of items in that category.

Show
Andrew Davis added a comment - It should allow the course total to be hidden independent of items in the course AND allow category totals to be hidden independent of items in that category.
Hide
Permalink
Andrew Davis added a comment -

This fix requires a database change so unfortunately it can't go into 1.9 You are however welcome to try the patch (on a non-production machine) to see whether it works how you would like and give me some feedback.

Show
Andrew Davis added a comment - This fix requires a database change so unfortunately it can't go into 1.9 You are however welcome to try the patch (on a non-production machine) to see whether it works how you would like and give me some feedback.
Hide
Permalink
Elena Ivanova added a comment -

Andrew, do you by any chance have some testing environment where we can look at it? Similar to http://test.moodle.net/
I would love to test and provide feedback, but not have any skills in setting up moodle instances.

Show
Elena Ivanova added a comment - Andrew, do you by any chance have some testing environment where we can look at it? Similar to http://test.moodle.net/ I would love to test and provide feedback, but not have any skills in setting up moodle instances.
Hide
Permalink
Andrew Davis added a comment -

I've committed this into the moodle 2 branch.

Elena, as it has been committed into moodle 2 this functionality should shortly be available in any test sites running the latest version of moodle 2.

Show
Andrew Davis added a comment - I've committed this into the moodle 2 branch. Elena, as it has been committed into moodle 2 this functionality should shortly be available in any test sites running the latest version of moodle 2.
Hide
Permalink
Elena Ivanova added a comment -

Thank you, Andrew.
Anyone this ticket knows by a chance who is running http://test.moodle.net/head and how often it is updated?

Show
Elena Ivanova added a comment - Thank you, Andrew. Anyone this ticket knows by a chance who is running http://test.moodle.net/head and how often it is updated?
Hide
Permalink
Helen Foster added a comment -

Hi Elena,

http://test.moodle.net/head hasn't been updated for quite a while. However, the Moodle 2.0 QA Testing Site should hopefully be available soon.

Show
Helen Foster added a comment - Hi Elena, http://test.moodle.net/head hasn't been updated for quite a while. However, the Moodle 2.0 QA Testing Site should hopefully be available soon.
Hide
Permalink
Elena Ivanova added a comment -

Thank you, Helen. That would be a great help!

Show
Elena Ivanova added a comment - Thank you, Helen. That would be a great help!
Hide
Permalink
Martin Dougiamas added a comment -

This can't be solved in Moodle 1.9 the same way as Moodle 2, but the workaround will be to use the new setting in MDL-21218, which lets you hide the course total when any of the items are hidden. So as long as one item is hidden (a real one or even a fake one) then the total won't be visible.

Show
Martin Dougiamas added a comment - This can't be solved in Moodle 1.9 the same way as Moodle 2, but the workaround will be to use the new setting in MDL-21218, which lets you hide the course total when any of the items are hidden. So as long as one item is hidden (a real one or even a fake one) then the total won't be visible.

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.