|
Tim Hunt made changes - 07/Jul/09 03:37 PM
[
Permalink
| « Hide
]
David Mudrak added a comment - 07/Jul/09 06:46 PM
Fixed URL
David Mudrak made changes - 07/Jul/09 06:46 PM
See the attached 0001 patch for the proposed implementation
If you are using git, you can run Non-gitters will just remove some lines from the top of the patch file to get pure diff
David Mudrak made changes - 07/Jul/09 08:12 PM
Yes, the tests passed. I modified some of the current tests a bit - I know I should not do that but I felt I am doing right thing, hopefully. Also, I added some more to test the variations of calls with the new parameter. The new parameter works for my needs.
To be reviewed more carefully: how I integrated this into the templateable renderers as I am not very confident in this area. Thanks in advance. Doh! that was an interesting typo. I mean to say Please commit.
However, you are right template_renderer_factory needs a bit more work. In get_renderer, the $searchpaths array needs to $path = $rootpath . '/' . $module; Is probably a good way to do it. Anyway, template renderer is only an experimental proof-of-concept. No need to be too concerned with it now. Well, this was my original intention to keep all templates in one directory. But you are right, subdirectories templates should respect the subtypes.
p.s. I like the typo. Maybe we can start using "Fix a lot" instead "Thanks a lot" and so on
David Mudrak committed 3 files to 'Moodle CVS' - 08/Jul/09 05:37 PM
Committed. I have fixed the template_renderer_factory::get_renderer() so it sets up folders for subtypes. This involved a little extension of the unit test.
David Mudrak made changes - 08/Jul/09 05:39 PM
Tim Hunt made changes - 08/Jul/09 09:47 PM
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||