Moodle

Upgrade blog code to new OUTPUT and PAGE APIs

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 2.0
  • Component/s: Other
  • Labels:
    None
  • Affected Branches:
    MOODLE_20_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Activity

Hide
Sam Hemelryk added a comment -

Hey Nicolas,
I've come up with a patch to elimate the last couple of print_header and build_navigation calls in blog.
However I would like you to have a look at it if possible, I couldn't work out the header.php and blog_page::print_header.

  • header.php builds a navlinks array but I couldn't see where it was used.
  • blog_page::print_header calls print_header but I'm not sure where it's conversion would be to call it's own set methods, or globalize $PAGE and use it
    s set methods?
Show
Sam Hemelryk added a comment - Hey Nicolas, I've come up with a patch to elimate the last couple of print_header and build_navigation calls in blog. However I would like you to have a look at it if possible, I couldn't work out the header.php and blog_page::print_header.
  • header.php builds a navlinks array but I couldn't see where it was used.
  • blog_page::print_header calls print_header but I'm not sure where it's conversion would be to call it's own set methods, or globalize $PAGE and use it s set methods?
Hide
Sam Hemelryk added a comment -

All deprecated functions have been converted

Show
Sam Hemelryk added a comment - All deprecated functions have been converted

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: