Moodle

Bug in si_utf8 language pack

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.9.5, 2.0
  • Fix Version/s: None
  • Component/s: Language
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE, MOODLE_20_STABLE

Description

Bug is related to MDL-18841 and MDL-17358.
Specifically see Tim's comment here http://tracker.moodle.org/browse/MDL-17358?focusedCommentId=68384&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_68384

This string (and probably others) in si_utf8/moodle.php:$string['pictureof'] = '$a?? ????????';

Creates the following PHP output:
[error] [client X.X.X.X] PHP Notice: Undefined variable: a\xe0\xb6\x9c\xe0\xb7\x9a in /lib/moodlelib.php(5433) : eval()'d code on line 1

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Tim Hunt added a comment -

Stupid tracker, why can't it cope with multibyte characters. Anyway, you can see the problem string at http://cvs.moodle.org/lang/si_utf8/moodle.php?view=markup.

Show
Tim Hunt added a comment - Stupid tracker, why can't it cope with multibyte characters. Anyway, you can see the problem string at http://cvs.moodle.org/lang/si_utf8/moodle.php?view=markup.
Hide
Permalink
Koen Roggemans added a comment -

adding Rashan (the Sinhala translator) too

Show
Koen Roggemans added a comment - adding Rashan (the Sinhala translator) too
Hide
Permalink
Rashan Anushka added a comment -

It seems that we are missing a space after "a". BTW I also voted for http://tracker.moodle.org/browse/MDL-18841 as that seems to be a long term solution.

Show
Rashan Anushka added a comment - It seems that we are missing a space after "a". BTW I also voted for http://tracker.moodle.org/browse/MDL-18841 as that seems to be a long term solution.
Hide
Permalink
David Mudrak added a comment -

Rashan, try using the {} brackets to wrap $a placeholders:

$string['pictureof'] = '{$a}blahblah';
Show
David Mudrak added a comment - Rashan, try using the {} brackets to wrap $a placeholders: 
$string['pictureof'] = '{$a}blahblah';
Hide
Permalink
Rashan Anushka added a comment -

David, I already did that for the string causing this bug. However, I will follow this convention in future for any new strings. When time permits, I also try to fix any existing strings.

Show
Rashan Anushka added a comment - David, I already did that for the string causing this bug. However, I will follow this convention in future for any new strings. When time permits, I also try to fix any existing strings.
Hide
Permalink
David Mudrak added a comment -

OK, so can we close this issue?

Show
David Mudrak added a comment - OK, so can we close this issue?
Hide
Permalink
Koen Roggemans added a comment -

Sinhala language pack is apparently fixed. MDL-18841 will solve the problem permanently

Show
Koen Roggemans added a comment - Sinhala language pack is apparently fixed. MDL-18841 will solve the problem permanently

People

Vote (0)
Watch (4)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.