[#MDL-19890] Fix up old block_setup/printing calls in mod/lesson - Moodle Tracker

Details

Type: Sub-task
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 2.0
Fix Version/s: 2.0
Component/s: Lesson
Labels:
None

Affected Branches:
MOODLE_20_STABLE
Fixed Branches:
MOODLE_20_STABLE

Description

This was not done at the time I committed http://git.moodle.org/gw?p=moodle.git;a=commit;h=d4a03c00ea3885ac2b264b7d7a8c6c635d5714d2

More Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

lesson_blocks.patch

22/Jul/09 4:42 PM

30 kB

Tim Hunt

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Tim Hunt added a comment - 22/Jul/09 4:42 PM

Mark, I think this patch fixes lesson. However, I don't think I understand lesson well enough to test this properly.

Do you have time to take a look?

Well, timer is broken becuase it uses document.write in a way that relies on being an inline script which is horrible. I don't really want to try to fix that now. Any chance you could have a look at stealing the updated clock JavaScript from quiz? If you don't have time, I'll get Sam Hemelryk onto fixing it.

If you think it is basically OK, I will commit these changes. I hope you agree that the general way the new code works is nicer than the old way.

Show

Tim Hunt added a comment - 22/Jul/09 4:42 PM Mark, I think this patch fixes lesson. However, I don't think I understand lesson well enough to test this properly. Do you have time to take a look? Well, timer is broken becuase it uses document.write in a way that relies on being an inline script which is horrible. I don't really want to try to fix that now. Any chance you could have a look at stealing the updated clock JavaScript from quiz? If you don't have time, I'll get Sam Hemelryk onto fixing it. If you think it is basically OK, I will commit these changes. I hope you agree that the general way the new code works is nicer than the old way.

Hide

Permalink

Tim Hunt added a comment - 23/Jul/09 6:02 PM

After a bit more testing, and fixing the timer a bit (it still need to be changed to not use document.write, or it with not work with strict XHTML headers) I have decided it is OK to check this in.

Show

Tim Hunt added a comment - 23/Jul/09 6:02 PM After a bit more testing, and fixing the timer a bit (it still need to be changed to not use document.write, or it with not work with strict XHTML headers) I have decided it is OK to check this in.

People

Assignee:

Tim Hunt

Reporter:

Tim Hunt

Participants:

Tim Hunt

Vote (0)

Watch (1)

Dates

Created:

21/Jul/09 4:04 PM

Updated:

17/Dec/10 12:53 PM

Resolved:

23/Jul/09 6:02 PM