Details
Bug
Major
Description
Hi all,
We have once more a problem witch course backups. A couple of tests figured out that the problem is related to quizzes. Please follow the steps to reproduce the bug.
1. Create a question category which is associated with a course category.
2. Create a multiple choice question and insert a picture into the question using the "Image to display" field. The image should be used nowhere else as content in the course.
3. Create a quiz with this question
4. Try to make a backup of the course including user data and the quiz
Following errors will be shown up:
Linked file images/pic.jpg doesn't exist
When you exclude the quizzes from the backup, there will be no error.
I can reproduce this issue on two different moodle installations.
Attachments
Issue Links
| This issue will be resolved by: | ||||
| MDL-15861 | Course backup connot find linked quiz pictures |
|
|
|
Activity
Hi Karsten,
can you confirm if the same happens with current Moodle 1.9.7+ ?
I've followed your steps 1-4, using one image stored in site files in one question belonging to one category... and the backup is executed perfectly, with the image being included ok and without any error.
I've:
- category1 (which default questions category contains one multichoice question using one site image).
- course1 in category1: with one quiz using the question above. It's displayed ok and included in backup ok too.
Not sure if that's 100% your situation.
Ciao 
- category1 (which default questions category contains one multichoice question using one site image).
- course1 in category1: with one quiz using the question above. It's displayed ok and included in backup ok too.
Hello to all
I can confirm that the bug is still in a Moodle 1.9.8 (Build: 20100326).
As far as I could analyse the problem the backup and the restore works - but on the first page after starting the backup the errors are shown! These errors are in my opinion "false negative" error-messages because
- the images are there
- they get included in the backup
- the restore brings the images back again
- and as far as I could see the restored tests work.
But the normal users (and we have "some" of them ) are afraid because of the error messages.
Andreas
- the images are there
- they get included in the backup
- the restore brings the images back again
- and as far as I could see the restored tests work.
) are afraid because of the error messages.
Andreas Hello again, probably especially to you Eloy as the assignee for this
My last suggestion to fix this bug was not ok. After testing this I had to recognize that now an error while copying site files is coming up. So I analysed the code a little bit deeper.
As I understand this the work of the problematic function should be to detect all files in questions that do not exist in the course files but only on site level. Because normally all linked files in a question exist on course level the function is not able to find the files on site level. The problem seems to be that the function only looks for linked files and does not distinguish between files on course and on site level. All course files are searched on site level where they normally do not exist - and then the error-message arises.
I have now a new solution to solve the problem - not nice but it seems to work. The flow of logic would be the following:
- The first if() is untouched. It looks whether the file exists on site level.
- In the else-part of this if() there was until now only a notification that the file does not exist when not found on site level.
- I now introduced a nested if() in the else-part and look whether the file exists on course level. If yes nothing has to be done, if not the notification is sent.
The code now looks like this and I hope this is now better (code startin in line 504):
foreach (array_keys($urls) as $url){
/* SITEID has the value 1. First test whether file exists on site-level */
if (file_exists($CFG->dataroot.'/'.SITEID.'/'.$url)){
$inserturl = new object();
$inserturl->backup_code = $backup_unique_code;
$inserturl->file_type = 'site';
$url = clean_param($url, PARAM_PATH);
$inserturl->path = addslashes($url);
$status = $status && insert_record('backup_files', $inserturl);
} else {
/* Ok, file does not exist on site-level, perhaps on course-level? */
if (!file_exists($CFG->dataroot.'/'.$course.'/'.$url)){
notify(get_string('linkedfiledoesntexist', 'question', $url));
}
}
}
A diff of the old to the new code gives me:
504a505
> /* SITEID has the value 1. First test whether file exists on site-level */
513c514,517
< notify(get_string('linkedfiledoesntexist', 'question', $url));
---
> /* Ok, file does not exist on site-level, perhaps on course-level? */
> if (!file_exists($CFG->dataroot.'/'.$course.'/'.$url)){
> notify(get_string('linkedfiledoesntexist', 'question', $url));
> }
Is this a better solution that works for all of you?
Andreas
My last suggestion to fix this bug was not ok. After testing this I had to recognize that now an error while copying site files is coming up. So I analysed the code a little bit deeper.
As I understand this the work of the problematic function should be to detect all files in questions that do not exist in the course files but only on site level. Because normally all linked files in a question exist on course level the function is not able to find the files on site level. The problem seems to be that the function only looks for linked files and does not distinguish between files on course and on site level. All course files are searched on site level where they normally do not exist - and then the error-message arises.
I have now a new solution to solve the problem - not nice but it seems to work. The flow of logic would be the following:
- The first if() is untouched. It looks whether the file exists on site level.
- In the else-part of this if() there was until now only a notification that the file does not exist when not found on site level.
- I now introduced a nested if() in the else-part and look whether the file exists on course level. If yes nothing has to be done, if not the notification is sent.
foreach (array_keys($urls) as $url){
/* SITEID has the value 1. First test whether file exists on site-level */
if (file_exists($CFG->dataroot.'/'.SITEID.'/'.$url)){
$inserturl = new object();
$inserturl->backup_code = $backup_unique_code;
$inserturl->file_type = 'site';
$url = clean_param($url, PARAM_PATH);
$inserturl->path = addslashes($url);
$status = $status && insert_record('backup_files', $inserturl);
} else {
/* Ok, file does not exist on site-level, perhaps on course-level? */
if (!file_exists($CFG->dataroot.'/'.$course.'/'.$url)){
notify(get_string('linkedfiledoesntexist', 'question', $url));
}
}
}
504a505
> /* SITEID has the value 1. First test whether file exists on site-level */
513c514,517
< notify(get_string('linkedfiledoesntexist', 'question', $url));
---
> /* Ok, file does not exist on site-level, perhaps on course-level? */
> if (!file_exists($CFG->dataroot.'/'.$course.'/'.$url)){
> notify(get_string('linkedfiledoesntexist', 'question', $url));
> }
Please find attached a possible solution. A developer should have a look to the sql-statement.