Moodle

Gradebook doesn't display properly. Vertical misalignment.

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.9.5
  • Fix Version/s: 1.9.8
  • Component/s: Gradebook
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

There is vertical misalignment of rows. which inceases the possibility of error. See Image attached.

Issue Links

This issue will be resolved by:
MDL-21088 vertical alignment problem on grader report in IE with static student columns Trivial Closed
This issue has been marked as being related by:
MDL-18228 Add horizontal scrollbar to the grader report Minor Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Greg Kraus added a comment -

I can replicate this with IE 7, specifically, 7.0.5730.13. Firefox on Windows seems fine.

Show
Greg Kraus added a comment - I can replicate this with IE 7, specifically, 7.0.5730.13. Firefox on Windows seems fine.
Hide
Permalink
Greg Kraus added a comment -

same problem in IE 8

Show
Greg Kraus added a comment - same problem in IE 8
Hide
Permalink
Laura Mikowychok added a comment -

I'm actually able to duplicate the problem in Firefox on a Mac, and it permeates to not just misaligned rows, but that when I enter a grade, it enters on the wrong user (3 or 4 users away vertically), or when I click on a user to highlight the horizontal row in yellow, clicking highlights the wrong user. This is MAJOR for accuracy in grading.

Show
Laura Mikowychok added a comment - I'm actually able to duplicate the problem in Firefox on a Mac, and it permeates to not just misaligned rows, but that when I enter a grade, it enters on the wrong user (3 or 4 users away vertically), or when I click on a user to highlight the horizontal row in yellow, clicking highlights the wrong user. This is MAJOR for accuracy in grading.
Hide
Permalink
Laura Mikowychok added a comment -

The user who has the red line through the name is the one I clicked on, and the resulting yellow highlighting occured several rows down.

Zoom on browser window was at 100%; browser was Firefox, newest release, on a Mac.

Show
Laura Mikowychok added a comment - The user who has the red line through the name is the one I clicked on, and the resulting yellow highlighting occured several rows down. Zoom on browser window was at 100%; browser was Firefox, newest release, on a Mac.
Hide
Permalink
Nicholas McJetters added a comment -

Just wanted to add this behavior occurs when Static students column is checked in Site Administration > Grades > Report Settings > Grader Report > Static students column. Anyone know when this checkbox/feature debuted in what tracker #?

Show
Nicholas McJetters added a comment - Just wanted to add this behavior occurs when Static students column is checked in Site Administration > Grades > Report Settings > Grader Report > Static students column. Anyone know when this checkbox/feature debuted in what tracker #?
Hide
Permalink
Nicholas McJetters added a comment -

Possible theme issue?

Show
Nicholas McJetters added a comment - Possible theme issue?
Hide
Permalink
Greg Kraus added a comment -

We found that it was a theme issue, but it impacted some built-in Moodle themes as well, namely Custom Corners.

One of our themes had misdefined a table cell style that didn't have any impact until the new gradebook was introduced. Once we fixed that it worked pretty well. There is still a 1 or 2 pixel misalignment, but the misalignment didn't get worse - it just stayed constant.

Show
Greg Kraus added a comment - We found that it was a theme issue, but it impacted some built-in Moodle themes as well, namely Custom Corners. One of our themes had misdefined a table cell style that didn't have any impact until the new gradebook was introduced. Once we fixed that it worked pretty well. There is still a 1 or 2 pixel misalignment, but the misalignment didn't get worse - it just stayed constant.
Hide
Permalink
Greg Kraus added a comment -

I went back and looked at our themes - I think the incorrect rule we had was

th,td {margin:0;padding:0;}

It was part of a general CSS reset file. Removing those two rules fixed most of it.

Show
Greg Kraus added a comment - I went back and looked at our themes - I think the incorrect rule we had was th,td {margin:0;padding:0;} It was part of a general CSS reset file. Removing those two rules fixed most of it.
Hide
Permalink
Greg Kraus added a comment -

To fix the custom corners theme we added the following two rules to user_styles.css in the custom_corners theme folder

td.controls, th.controls {
height:3em !important;
}

.grade-report-grader div.left_scroller tr,
.grade-report-grader div.right_scroller td,
.grade-report-grader div.right_scroller th {
height:4.3em;
}

Show
Greg Kraus added a comment - To fix the custom corners theme we added the following two rules to user_styles.css in the custom_corners theme folder td.controls, th.controls { height:3em !important; } .grade-report-grader div.left_scroller tr, .grade-report-grader div.right_scroller td, .grade-report-grader div.right_scroller th { height:4.3em; }
Hide
Permalink
Paul Vaughan added a comment -

Same issue, very specific to IE7 (and also IE8 in IE7 Compatibility Mode).

I thought it was a theme issue and will try out the above recommendations.

Show
Paul Vaughan added a comment - Same issue, very specific to IE7 (and also IE8 in IE7 Compatibility Mode). I thought it was a theme issue and will try out the above recommendations.
Hide
Permalink
Paul Vaughan added a comment -

In the uploaded image, 1 is how Firefox / Chrome / IE8 renders the gradebook, and 2 is how IE7 renders it.

Show
Paul Vaughan added a comment - In the uploaded image, 1 is how Firefox / Chrome / IE8 renders the gradebook, and 2 is how IE7 renders it.
Hide
Permalink
Paul Vaughan added a comment -

I have tried Greg Kraus' suggestion and it did not work for us. (We are using a modified version of the custom corners theme.)

Any further help with this issue would be hugely appreciated, as 1) it looks bad and 2) (much more serious) could result in grade modifications/comments being attributed to the wrong student, which could have serious repercussions.

Show
Paul Vaughan added a comment - I have tried Greg Kraus' suggestion and it did not work for us. (We are using a modified version of the custom corners theme.) Any further help with this issue would be hugely appreciated, as 1) it looks bad and 2) (much more serious) could result in grade modifications/comments being attributed to the wrong student, which could have serious repercussions.
Hide
Permalink
Andrew Davis added a comment -

Hello. Just letting you know I've got patches awaiting review in MDL-21088 that should resolve this. It should be fixed in 1.9.8

Show
Andrew Davis added a comment - Hello. Just letting you know I've got patches awaiting review in MDL-21088 that should resolve this. It should be fixed in 1.9.8
Hide
Permalink
Andrew Davis added a comment -

Fix was committed against MDL-21088.

Show
Andrew Davis added a comment - Fix was committed against MDL-21088.

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.