Issue Details (XML | Word | Printable)

Key: MDL-19935
Type: Improvement Improvement
Status: Open Open
Priority: Major Major
Assignee: Sam Hemelryk
Reporter: Tim Hunt
Votes: 0
Watchers: 4
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Always include YUI CSS via the theme CSS so we don't have to worry about doing $PAGE->requires->yui_lib before $OUTPUT->header

Created: 27/Jul/09 10:37 AM   Updated: 26/Aug/09 03:16 AM
Return to search
Component/s: AJAX
Affects Version/s: 2.0
Fix Version/s: 2.0

File Attachments: 1. Text File MDL-19935.20090817.patch (11 kB)
2. Text File MDL-19935.20090818.patch (12 kB)
3. Text File MDL-19935.20090819.fixed.patch (18 kB)
4. Text File MDL-19935.20090819.patch (18 kB)


Participants: Petr Skoda, Sam Hemelryk and Tim Hunt
Security Level: None
Affected Branches: MOODLE_20_STABLE
Fixed Branches: MOODLE_20_STABLE


 Description  « Hide
At the moment we have an annoying problem where some YUI libraries rely on related CSS files. This means that if you do $PAGE->requries->yui_lib on some libraries after $OUTPUT->header you get an exception.

Instead, we should adopt an approach more like we do with plugin sheets. There should be a $THEME->yuisheets in theme_config which defaults to true, and if that is true, then theme/styles.php should include all the CSS for all the YUI components in the output it is building.

The list of CSS files that are needed should come from the big array of dependencies in ajaxlib.php

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Sam Hemelryk made changes - 17/Aug/09 02:48 PM
Field Original Value New Value
Attachment MDL-19935.20090817.patch [ 18189 ]
Sam Hemelryk made changes - 18/Aug/09 10:58 AM
Attachment MDL-19935.20090818.patch [ 18193 ]
Sam Hemelryk made changes - 19/Aug/09 04:02 PM
Attachment MDL-19935.20090819.patch [ 18204 ]
Sam Hemelryk made changes - 19/Aug/09 04:07 PM
Attachment MDL-19935.20090819.fixed.patch [ 18205 ]