Moodle

Stage height and width, and TOC size cannot be set

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.9.5
  • Fix Version/s: 2.0
  • Component/s: SCORM
  • Labels:
    None
  • Environment:
    Windows clients (not tried in Linux). This appears to be common across browsers -affects IE6+ and Firefox 2+.
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

We have created SCORM objects which should display correctly on 1024 x 768 resoultion screens. However since upgrading to 1.9+ setting the stage height to anything less than 1100 px results in vertical scroll bars appearing in the SCORM window. A setting of 1100 gets rid of the verical scroll bars, but then there is a large gap at the bottom of the frame between the content and where any horizontal scroll bar might sit.

This is important because in addition to the above, the TOC window is too wide and results in a horizontal scroll bar appearing in the SCORM window. However, the user may not see it, as the increased stage height has pushed the scroll bar off the screen. Therefore the user is often unable to see some of the content, including navigation buttons. There doesn't seem to be any way of setting the relative widths of the TOC and main SCORM areas.

I've attached screen shots to illustrate the problem. They were all taken in Firefox with a 1024 x x768 browser size.

Attachments

  1. JPEG File
    1100 stage_height_top.jpg
    29/Jul/09 3:49 PM
    214 kB
    Sid Verber
  2. Text File
    player.php.patch
    27/Jan/10 7:19 AM
    0.7 kB
    Jesús Rincón
  3. Text File
    rd.js.patch
    27/Jan/10 7:19 AM
    2 kB
    Jesús Rincón
  1. 1100px_stage_height_standard_theme_bottom.jpg
    100 kB
    29/Jul/09 4:11 PM
  2. 1100px_stage_height_standard_theme_top.jpg
    213 kB
    29/Jul/09 4:11 PM
  3. 1100 stage_height_bottom.jpg
    102 kB
    29/Jul/09 3:49 PM
  4. 800px stage height.jpg
    208 kB
    29/Jul/09 3:49 PM

Issue Links

This issue is a clone of:
MDL-9378 New visualization for SCORM Critical Closed
This issue will be resolved by:
MDL-22951 replace SCORM player with similar player from IMSCP Module Major Closed
This issue is duplicated by:
MDL-19191 SCORM stage size - width control has no effect on iFrame Minor Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Dan Marsden added a comment -

Hi Sid,

thanks for the details! - can you please re-test with the standard Moodle theme? - a large number of scorm related display issues are related to peoples custom themes - so it's always good to eliminate those first.

thanks.

Show
Dan Marsden added a comment - Hi Sid, thanks for the details! - can you please re-test with the standard Moodle theme? - a large number of scorm related display issues are related to peoples custom themes - so it's always good to eliminate those first. thanks.
Hide
Permalink
Sid Verber added a comment -

Hi Dan

I had already tried that, but have just done so again. I've attached screen shots I've just made, using the standard Moodle theme. Same issue as before. It does seem to be an issue, as there have been a number of forum postings relating to stage size (particularly height).

Best wishes

Sid

Show
Sid Verber added a comment - Hi Dan I had already tried that, but have just done so again. I've attached screen shots I've just made, using the standard Moodle theme. Same issue as before. It does seem to be an issue, as there have been a number of forum postings relating to stage size (particularly height). Best wishes Sid
Hide
Permalink
Sid Verber added a comment -

These are screen shots using the standard theme

Show
Sid Verber added a comment - These are screen shots using the standard theme
Hide
Permalink
Dan Marsden added a comment -

thanks for that! - to be honest, the css in SCORM needs a bit of work and doesn't really comply with Moodle's theming guidelines...

I've been wondering for a while about the stage height/width and why we actually allow them to be set by the module.... unfortunately there isn't any funding allocated to SCORM maintenance at the moment, so this will sit on our todo list for a while.... unless someone comes up with a patch which I'd be happy to review!

Show
Dan Marsden added a comment - thanks for that! - to be honest, the css in SCORM needs a bit of work and doesn't really comply with Moodle's theming guidelines... I've been wondering for a while about the stage height/width and why we actually allow them to be set by the module.... unfortunately there isn't any funding allocated to SCORM maintenance at the moment, so this will sit on our todo list for a while.... unless someone comes up with a patch which I'd be happy to review!
Hide
Permalink
Petr Škoda (skodak) added a comment -

hello, I just spent a few days fighting similar issues in new imscp resource module in 20dev.
I ended up doing some crazy YUI magic, maybe some bits could be later reused in this module.

Show
Petr Škoda (skodak) added a comment - hello, I just spent a few days fighting similar issues in new imscp resource module in 20dev. I ended up doing some crazy YUI magic, maybe some bits could be later reused in this module.
Hide
Permalink
David Puente Bautista added a comment -

Is there any news on it? I could spend some money for solve this scorm problem view... It's horrible!

Show
David Puente Bautista added a comment - Is there any news on it? I could spend some money for solve this scorm problem view... It's horrible!
Hide
Permalink
Dan Marsden added a comment -

Hi David,

Most view related issues are related to people using non-standard themes, however the SCORM CSS is known to be pretty bad, and could do with some improvement.

If the issues you are having are not related to a custom theme you have on your site, and you were willing to pay for it to be improved, you could contact your local Moodle Partner to do the work for you.
see
http://moodle.com/partners/list

thanks,

Show
Dan Marsden added a comment - Hi David, Most view related issues are related to people using non-standard themes, however the SCORM CSS is known to be pretty bad, and could do with some improvement. If the issues you are having are not related to a custom theme you have on your site, and you were willing to pay for it to be improved, you could contact your local Moodle Partner to do the work for you. see http://moodle.com/partners/list thanks,
Hide
Permalink
David Puente Bautista added a comment -

I have tried with standar themes with no success... I will put in contact with CVA (spanis partner) and I hope they can solve it.
Thanks!

Show
David Puente Bautista added a comment - I have tried with standar themes with no success... I will put in contact with CVA (spanis partner) and I hope they can solve it. Thanks!
Hide
Permalink
Jesús Rincón added a comment -

Hi David:
If the page showing the SCORM is footer must show both bars, but SCORM window would be very small.

Can you attach a screenshot?

Regards

Show
Jesús Rincón added a comment - Hi David: If the page showing the SCORM is footer must show both bars, but SCORM window would be very small. Can you attach a screenshot? Regards
Hide
Permalink
Sid Verber added a comment -

I'm still getting the problem in 1.9.7+. The vertical scroll bars shown in my original screen dumps above appear even if I revert to the standard theme. As said in my original posting, I can partially solve the problem by setting the vertical stage size to 1100 px (even though the actual SCORM object size is only around 600 - 700 px deep). However this then pushes any horizontal scroll bar out of sight.

The key point which I think is being missed, which may help in solving the problem, is that this was not a problem in 1.8.+. Therefore whatever is causing it is a result of changes to the SCORM module between 1.8 and 1.9. If someone could identify which of those changes might have affected the stage size setting routine, it should be possible to fix.

Any ideas?

Best wishes

Sid

Show
Sid Verber added a comment - I'm still getting the problem in 1.9.7+. The vertical scroll bars shown in my original screen dumps above appear even if I revert to the standard theme. As said in my original posting, I can partially solve the problem by setting the vertical stage size to 1100 px (even though the actual SCORM object size is only around 600 - 700 px deep). However this then pushes any horizontal scroll bar out of sight. The key point which I think is being missed, which may help in solving the problem, is that this was not a problem in 1.8.+. Therefore whatever is causing it is a result of changes to the SCORM module between 1.8 and 1.9. If someone could identify which of those changes might have affected the stage size setting routine, it should be possible to fix. Any ideas? Best wishes Sid
Hide
Permalink
Dan Marsden added a comment -

it could have been the large visualisation patch that went in - but SCORM display was much worse prior to that! the major issue is really MDL-7787 - time should be spent on that bug - possibly using some YUI magic as Petr mentions to make it work really well. This isn't something that I have time to spend on unless someone provides some funding to get it done.

As always I'm happy to help review any patches for inclusion in core if someone else does this work.

Show
Dan Marsden added a comment - it could have been the large visualisation patch that went in - but SCORM display was much worse prior to that! the major issue is really MDL-7787 - time should be spent on that bug - possibly using some YUI magic as Petr mentions to make it work really well. This isn't something that I have time to spend on unless someone provides some funding to get it done. As always I'm happy to help review any patches for inclusion in core if someone else does this work.
Hide
Permalink
Jesús Rincón added a comment -

With these small changes are going to try to solve the problem of double bar:

  • Delete the footer content on the player.
  • Modify the function rd.js to rein scormcontent height, so when the scorm is by no means a suitable length review shows:

Try this change and tell me if it works or not.

These patches are made on moodle 1.9.7

Show
Jesús Rincón added a comment - With these small changes are going to try to solve the problem of double bar:
  • Delete the footer content on the player.
  • Modify the function rd.js to rein scormcontent height, so when the scorm is by no means a suitable length review shows:
Try this change and tell me if it works or not. These patches are made on moodle 1.9.7
Hide
Permalink
Sid Verber added a comment -

I tried the patch, but it didn't seem to work in Firefox. I'm going to try in IE7 next.

Sid

Show
Sid Verber added a comment - I tried the patch, but it didn't seem to work in Firefox. I'm going to try in IE7 next. Sid
Hide
Permalink
Dan Marsden added a comment -

the imscp module in Moodle 2.0 uses quite a nice player - we're keen to replace the SCORM player with a similar player - would be great to get some feedback from people who have used/seen the imscp player in 2.0!

Show
Dan Marsden added a comment - the imscp module in Moodle 2.0 uses quite a nice player - we're keen to replace the SCORM player with a similar player - would be great to get some feedback from people who have used/seen the imscp player in 2.0!
Hide
Permalink
Dan Marsden added a comment -

I'd really like some feedback for plans around replacing the SCORM player - I've posted here:
http://moodle.org/mod/forum/discuss.php?d=152895

really appreciate it if people here could comment/add their thoughts to the discussion - the quicker we are able to agree on a plan, the quicker we will be able to move forward and fix it.

Show
Dan Marsden added a comment - I'd really like some feedback for plans around replacing the SCORM player - I've posted here: http://moodle.org/mod/forum/discuss.php?d=152895 really appreciate it if people here could comment/add their thoughts to the discussion - the quicker we are able to agree on a plan, the quicker we will be able to move forward and fix it.
Hide
Permalink
Sid Verber added a comment -

Hi Dan

I don't have Moodle 2.0 installed yet, so can't comment as yet. I did find a workaround that seemed to be effective in 1.9.x. However I'd be happier with a permanent fix, so looking forward to 2.0 release. The workaround was at http://moodle.org/mod/forum/discuss.php?d=112909&parent=597545.

I'll try and install test the imscp module if I can

Show
Sid Verber added a comment - Hi Dan I don't have Moodle 2.0 installed yet, so can't comment as yet. I did find a workaround that seemed to be effective in 1.9.x. However I'd be happier with a permanent fix, so looking forward to 2.0 release. The workaround was at http://moodle.org/mod/forum/discuss.php?d=112909&parent=597545. I'll try and install test the imscp module if I can
Hide
Permalink
Dan Marsden added a comment -

thanks Sid! - don't forget http://qa.moodle.net/ is also available for testing.

Show
Dan Marsden added a comment - thanks Sid! - don't forget http://qa.moodle.net/ is also available for testing.
Hide
Permalink
Dan Marsden added a comment -

Piers has rewritten the SCORM player as part of MDL-22951 and this is now in HEAD - Kudos to Piers!

Show
Dan Marsden added a comment - Piers has rewritten the SCORM player as part of MDL-22951 and this is now in HEAD - Kudos to Piers!

People

Vote (1)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.