Moodle

Improve PostgreSQL generator code

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 2.0
  • Component/s: Database SQL/XMLDB
  • Labels:
    None
  • Difficulty:
    Moderate
  • Affected Branches:
    MOODLE_20_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

With PostgreSQL 8.3 as min requirement in Moodle 2.0, some oddities from previous versions can be avoided:

1) Use of temp columns each time one column is altered. PG 8.x supports direct changes.
2) default clause is allowed when adding fields.

Also, properly check XMLDB own tests and DB functional tests, related with these changes.

Activity

Hide
Eloy Lafuente (stronk7) added a comment -

Done and hopefully properly tested. Resolving as fixed.

Show
Eloy Lafuente (stronk7) added a comment - Done and hopefully properly tested. Resolving as fixed.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: