Moodle

Groups Add/remove users: Selected user's membership does not work with keyboard

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 2.0
  • Component/s: Accessibility, Groups
  • Labels:
    None
  • Environment:
    Firefox 3.5, Ubuntu 9.04

Description

Open a group for adding/removing users in it.
Use the tab key to enter the Potential members box.
Use the arrow keys to move between different users, to a user who is already in a group (there is a number in parentheses after the user's name)
Nothing appears in the Selected user's membership column

Attachments

  1. Text File
    clientlib.js.patch
    21/Dec/09 3:11 PM
    1 kB
    Andrew Davis
  2. Text File
    lib.patch
    21/Dec/09 3:11 PM
    4 kB
    Andrew Davis
  3. Text File
    members.patch
    21/Dec/09 3:11 PM
    1 kB
    Andrew Davis
  4. Text File
    styles_layout.patch.txt
    21/Dec/09 3:11 PM
    0.6 kB
    Andrew Davis
  1. Screenshot.png
    173 kB
    18/Nov/09 11:18 AM

Issue Links

This issue will help resolve:
MDL-14106 "Selected user's membership" in groups interface - does it work? Major Closed
This issue has been marked as being related by:
MDL-16994 Convert group memebership page Minor Closed
MDL-21166 Create more attractive UI for displaying user's other group members Minor Open

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Martin Dougiamas added a comment -

A more tricky one for you Andrew

Show
Martin Dougiamas added a comment - A more tricky one for you Andrew
Hide
Permalink
Andrew Davis added a comment -

This is a screenshot of the screen where you add members to a group. I think I'm looking at the correct screen.

Assuming I am on the correct page the left hand area is existing members of the group. The right hand area is users not currently in this group. Nothing happens under any condition when you select a user not in the group aside from them becoming selected so you can add them to the group.

Has the "selected user membership column" (which sounds like it lets you get a list of all groups this user belongs to) been removed or am I misunderstanding this?

Show
Andrew Davis added a comment - This is a screenshot of the screen where you add members to a group. I think I'm looking at the correct screen. Assuming I am on the correct page the left hand area is existing members of the group. The right hand area is users not currently in this group. Nothing happens under any condition when you select a user not in the group aside from them becoming selected so you can add them to the group. Has the "selected user membership column" (which sounds like it lets you get a list of all groups this user belongs to) been removed or am I misunderstanding this?
Hide
Permalink
Andrew Davis added a comment -

This work appears to have removed this functionality.

Show
Andrew Davis added a comment - This work appears to have removed this functionality.
Hide
Permalink
Andrew Davis added a comment -

I'm not sure what to do with this issue. It appears the third area, which displays the memberships of potential members, was removed as part of MDL-16994
http://tracker.moodle.org/browse/MDL-16994

Specifically these changes.
http://cvs.moodle.org/moodle/group/members.php?r1=1.14&r2=1.15
Look for this comment in the code to see the relevant removed code "// Get other groups user already belongs to"

Also, further down at line 114 the td where the third column was was removed along with related JS.

Should I reimplement this functionality in 2, was it pulled out for a good reason during the conversion from 1.9 to 2 or am I misunderstanding something?

Show
Andrew Davis added a comment - I'm not sure what to do with this issue. It appears the third area, which displays the memberships of potential members, was removed as part of MDL-16994 http://tracker.moodle.org/browse/MDL-16994 Specifically these changes. http://cvs.moodle.org/moodle/group/members.php?r1=1.14&r2=1.15 Look for this comment in the code to see the relevant removed code "// Get other groups user already belongs to" Also, further down at line 114 the td where the third column was was removed along with related JS. Should I reimplement this functionality in 2, was it pulled out for a good reason during the conversion from 1.9 to 2 or am I misunderstanding something?
Hide
Permalink
Andrew Davis added a comment -

After discussing this with Martin I'm putting this functionality back in. I've attached patches that should do it. Will wait for review before committing.

Show
Andrew Davis added a comment - After discussing this with Martin I'm putting this functionality back in. I've attached patches that should do it. Will wait for review before committing.
Hide
Permalink
Sam Hemelryk added a comment -

Hi Andrew, I have tested the above patches and things work fine.
The only question I have is, is displaying the groups that the user belongs to in a div beside the members selector the best way around this?
Would displaying this information within a YUI panel or such look better?
Anyway food for thought
Cheers
Sam

Show
Sam Hemelryk added a comment - Hi Andrew, I have tested the above patches and things work fine. The only question I have is, is displaying the groups that the user belongs to in a div beside the members selector the best way around this? Would displaying this information within a YUI panel or such look better? Anyway food for thought Cheers Sam
Hide
Permalink
Andrew Davis added a comment -

Committed. I copied that div approach simply because thats how it was done in 1.9. I'll open a seperate issue to look at better ways to display the information.

Show
Andrew Davis added a comment - Committed. I copied that div approach simply because thats how it was done in 1.9. I'll open a seperate issue to look at better ways to display the information.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.