Moodle

Restore Silently Isn't Silent

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9.3
  • Fix Version/s: 1.9.5
  • Component/s: Backup
  • Labels:
    None
  • Difficulty:
    Easy
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

Currently, restore_execute() [backup/restorelib.php] is not completely silent when RESTORE_SILENTLY.

For Moodle 1.9.3 (as reference because xref still points at 1.9.3):

7523 if ($status = restore_open_html($restore,$course_header)){ 7524 echo "<li>Creating the Restorelog.html in the course backup folder</li>"; 7525 }

Surrounding all other echoes in restore_execute() is this check:

if (!defined('RESTORE_SILENTLY')) {

Shouldn't the restorelog echo also be wrapped in a conditional that checks RESTORE_SILENTLY?

Issue Links

Activity

Hide
Dan Marsden added a comment -

duplicate - closing.

Show
Dan Marsden added a comment - duplicate - closing.
Hide
Rossiani Wijaya added a comment -

Duplicate.
Issue has been fix for HEAD and 1.9 Stable. (Refer to MDL-15276)
Closing

Show
Rossiani Wijaya added a comment - Duplicate. Issue has been fix for HEAD and 1.9 Stable. (Refer to MDL-15276) Closing

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: