Issue Details (XML | Word | Printable)

Key: MDL-20175
Type: Bug Bug
Status: Open Open
Priority: Critical Critical
Assignee: Sam Hemelryk
Reporter: Mike Churchward
Votes: 2
Watchers: 4
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Make Anomaly theme compatible for Moodle 2.0

Created: 27/Aug/09 09:52 PM   Updated: 08/Oct/09 09:58 PM
Return to search
Component/s: Installation, Themes
Affects Version/s: 2.0
Fix Version/s: 2.0

Issue Links:
Dependency
 

Participants: Martin Dougiamas, Mike Churchward, Patrick Malley and Sam Hemelryk
Security Level: None
Affected Branches: MOODLE_20_STABLE
Fixed Branches: MOODLE_20_STABLE


 Description  « Hide
Can no longer use the anomaly theme on 2.0. It also prevents upgrading.

Error is:

Notice: Undefined variable: OUTPUT in /var/www/moodle-head/theme/anomaly/header.html on line 36

Fatal error: Call to a member function container_start() on a non-object in /var/www/moodle-head/theme/anomaly/header.html on line 36

After removing the anomaly theme setting from the db, I get the error:

Unknown error upgrading qtype_calculated to version 2009082000, can not continue.

Clicking "continue" seems to fix the upgrade, but anomaly still cannot be used.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Sam Hemelryk added a comment - 14/Sep/09 10:52 AM
Hi Mike,
Just a quick note the error caused by qtype_calculated when upgrading was a seperate issue.
I've just created MDL-20275 (and commited a fix) for that bug.
Cheers
Sam

Sam Hemelryk added a comment - 14/Sep/09 12:09 PM
Hi Petr, talked this through with Martin.
He mentioned that you were looking to disable all old themes during upgrade as part of your changes to themes.

Martin Dougiamas added a comment - 24/Sep/09 04:21 PM
Next job for you, Sam. Can you please make Anomaly a First Class Moodle 2.0 theme? You'll need to convert header.html/footer.html into layout.php files, give it a new config.php and whatever else to make it look good. Thanks!

Martin Dougiamas added a comment - 24/Sep/09 04:22 PM
This theme should be a good example for Patrick Malley to use when converting other themes for Moodle 2.0

Patrick Malley added a comment - 07/Oct/09 06:24 PM
Do we have a timeframe for this work to be done? I've been putting off further development until I could see the new system I'd be coding for. I don't want to put things off too much longer or I'll be forced to rush right at the very end. Is there anything I can do to help test this?

Sam Hemelryk added a comment - 08/Oct/09 02:23 PM
Hi Patrick, I'm just waiting on Petr to check in some significant changes to the way in which themes work, once these changes have been checked in this will be given priority