Moodle

Make Anomaly theme compatible for Moodle 2.0

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 2.0
  • Component/s: Installation, Themes
  • Labels:
    None
  • Affected Branches:
    MOODLE_20_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

Can no longer use the anomaly theme on 2.0. It also prevents upgrading.

Error is:

Notice: Undefined variable: OUTPUT in /var/www/moodle-head/theme/anomaly/header.html on line 36

Fatal error: Call to a member function container_start() on a non-object in /var/www/moodle-head/theme/anomaly/header.html on line 36

After removing the anomaly theme setting from the db, I get the error:

Unknown error upgrading qtype_calculated to version 2009082000, can not continue.

Clicking "continue" seems to fix the upgrade, but anomaly still cannot be used.

Issue Links

This issue will help resolve:
MDL-20513 Make anomaly the default theme in Moodle 2.0 Minor Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Sam Hemelryk added a comment -

Hi Mike,
Just a quick note the error caused by qtype_calculated when upgrading was a seperate issue.
I've just created MDL-20275 (and commited a fix) for that bug.
Cheers
Sam

Show
Sam Hemelryk added a comment - Hi Mike, Just a quick note the error caused by qtype_calculated when upgrading was a seperate issue. I've just created MDL-20275 (and commited a fix) for that bug. Cheers Sam
Hide
Permalink
Sam Hemelryk added a comment -

Hi Petr, talked this through with Martin.
He mentioned that you were looking to disable all old themes during upgrade as part of your changes to themes.

Show
Sam Hemelryk added a comment - Hi Petr, talked this through with Martin. He mentioned that you were looking to disable all old themes during upgrade as part of your changes to themes.
Hide
Permalink
Martin Dougiamas added a comment -

Next job for you, Sam. Can you please make Anomaly a First Class Moodle 2.0 theme? You'll need to convert header.html/footer.html into layout.php files, give it a new config.php and whatever else to make it look good. Thanks!

Show
Martin Dougiamas added a comment - Next job for you, Sam. Can you please make Anomaly a First Class Moodle 2.0 theme? You'll need to convert header.html/footer.html into layout.php files, give it a new config.php and whatever else to make it look good. Thanks!
Hide
Permalink
Martin Dougiamas added a comment -

This theme should be a good example for Patrick Malley to use when converting other themes for Moodle 2.0

Show
Martin Dougiamas added a comment - This theme should be a good example for Patrick Malley to use when converting other themes for Moodle 2.0
Hide
Permalink
Patrick Malley added a comment -

Do we have a timeframe for this work to be done? I've been putting off further development until I could see the new system I'd be coding for. I don't want to put things off too much longer or I'll be forced to rush right at the very end. Is there anything I can do to help test this?

Show
Patrick Malley added a comment - Do we have a timeframe for this work to be done? I've been putting off further development until I could see the new system I'd be coding for. I don't want to put things off too much longer or I'll be forced to rush right at the very end. Is there anything I can do to help test this?
Hide
Permalink
Sam Hemelryk added a comment -

Hi Patrick, I'm just waiting on Petr to check in some significant changes to the way in which themes work, once these changes have been checked in this will be given priority

Show
Sam Hemelryk added a comment - Hi Patrick, I'm just waiting on Petr to check in some significant changes to the way in which themes work, once these changes have been checked in this will be given priority
Hide
Permalink
Sam Hemelryk added a comment -

Alrighty, I have attached a patch that refactors the anomaly theme in order for it to work with Moodle 2.0
It is still not perfect but the changes that Petr is still making to theme's will hopefully fix some of the issues, and after his work is complete and theme's have stabilised I (or someone else) will be able to get back in and fix up any final issues.
Cheers
Sam

Show
Sam Hemelryk added a comment - Alrighty, I have attached a patch that refactors the anomaly theme in order for it to work with Moodle 2.0 It is still not perfect but the changes that Petr is still making to theme's will hopefully fix some of the issues, and after his work is complete and theme's have stabilised I (or someone else) will be able to get back in and fix up any final issues. Cheers Sam
Hide
Permalink
Sam Hemelryk added a comment -

Will commit this on Wednesday as it is QA day today

Show
Sam Hemelryk added a comment - Will commit this on Wednesday as it is QA day today
Hide
Permalink
Sam Hemelryk added a comment -

Hi all,
I have just commit changes that get the anomaly theme working in Moodle 2.0.
It is still a long way from complete however at this point it is functioning and the remaining changes/fixes will be left until the remaining theme changes have been completed.

Show
Sam Hemelryk added a comment - Hi all, I have just commit changes that get the anomaly theme working in Moodle 2.0. It is still a long way from complete however at this point it is functioning and the remaining changes/fixes will be left until the remaining theme changes have been completed.
Hide
Permalink
Sam Hemelryk added a comment -

Just attached another patch, this one gets it working with the thee divs layout where the content is the first div.
Everything works fine in all tested browsers (inc. IE6) for what I have tested.
The following are the other changes:

  • all CSS has been rewritten and CSS I think is worth including in base theme is in a special base.css sheet.
  • Deleted all the old rounded corner images and recreated them in a much more optimised method, they are now four corners in each image and use a custom group index chart containing just the 16 colours they are made of.
  • Changed rounded corners to images unless the browser supports pure CSS rounded corners in which case they are used.

Known issues so far:

  • Tabs don't show correctly in IE6 (minor)
Show
Sam Hemelryk added a comment - Just attached another patch, this one gets it working with the thee divs layout where the content is the first div. Everything works fine in all tested browsers (inc. IE6) for what I have tested. The following are the other changes:
  • all CSS has been rewritten and CSS I think is worth including in base theme is in a special base.css sheet.
  • Deleted all the old rounded corner images and recreated them in a much more optimised method, they are now four corners in each image and use a custom group index chart containing just the 16 colours they are made of.
  • Changed rounded corners to images unless the browser supports pure CSS rounded corners in which case they are used.
Known issues so far:
  • Tabs don't show correctly in IE6 (minor)
Hide
Permalink
Sam Hemelryk added a comment -

Whoops totally forgot to tidy up the commenting before producing that patch, rest assured I will fix that up before commiting!

Show
Sam Hemelryk added a comment - Whoops totally forgot to tidy up the commenting before producing that patch, rest assured I will fix that up before commiting!

People

Vote (2)
Watch (4)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.