Issue Details (XML | Word | Printable)

Key: MDL-20188
Type: Bug Bug
Status: Open Open
Priority: Minor Minor
Assignee: Andreas Grabs
Reporter: Troy Williams
Votes: 1
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Feedback causing slow retrival of scales in gradebook.

Created: 31/Aug/09 09:46 AM   Updated: 12/Feb/10 07:08 AM
Component/s: Feedback
Affects Version/s: 1.9.5
Fix Version/s: None

Database: MySQL
Participants: Andreas Grabs, Doi Suthep and Troy Williams
Security Level: None
Affected Branches: MOODLE_19_STABLE


 Description  « Hide
Getting this error:
  • line 263 of lib/grade/grade_scale.php: call to debugging()
  • line 121 of grade/edit/scale/index.php: call to grade_scale->is_used()

Please notify the developer of module "feedback" that new function module_scale_used_anywhere() should be implemented.

Put following function into /mod/feedback/lib.php and has fixed problem.

/**

  • Checks if scale is being used by any instance of feedback
    *
  • This is used to find out if scale used anywhere
  • @param $scaleid int
  • @return boolean True if the scale is used by any forum
    */
    function feedback_scale_used_anywhere($scaleid) {

if ($scaleid and record_exists('feedback', 'scale', -$scaleid)) { return true; } else { return false; }
}

Regards,

Troy



 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Doi Suthep added a comment - 01/Feb/10 05:17 PM
Hi Troy,

Looking for an answer to the debugging error you commented, I have found this bug.

Does your patch fix the problem? If it does, maybe someone could update feedback with the patch on it.

Anyway unless someone fixes this on a different way, we would use your patch Troy, thanks for the fix.


Troy Williams added a comment - 12/Feb/10 07:08 AM
Hi Doi,

Yeah did solve problem. Sorry for taking so long to get back to you.

Regards,

Troy