[#MDL-20191] Subplugins are not uninstalled together with a module

Issue Details (XML | Word | Printable)

Key:	MDL-20191
Type:	Bug
Status:	Resolved
Resolution:	Fixed
Priority:	Blocker
Assignee:	David Mudrak
Reporter:	David Mudrak
Votes:	0
Watchers:	2

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

Subplugins are not uninstalled together with a module

Created: 31/Aug/09 11:18 PM Updated: 31/Aug/09 11:34 PM

Return to search

Component/s:

Administration

Affects Version/s:

2.0

Fix Version/s:

2.0

Issue Links:

Blockers

This issue blocks:

~~MDL-20192~~ workshop 2.0: turn grading and allocation methods into proper subplugins

Dependency

This issue will help resolve:

MDL-16438 centralise information about plugins to avoid duplication

Participants:	David Mudrak
Security Level:	None
QA Assignee:	Petr Skoda
Resolved date:	31/Aug/09
Affected Branches:	MOODLE_20_STABLE
Fixed Branches:	MOODLE_20_STABLE

Description

« Hide

This is a part of a complete subplugins support. When uninstalling a plugin (eg. mod/workshop), all the registered subplugins must be uninstalled, too.

All

Comments

Change History

Version Control

Sort Order:

David Mudrak made changes - 31/Aug/09 11:18 PM

Field	Original Value	New Value
Assignee	moodle.com [ moodle.com ]	David Mudrak [ mudrd8mz ]

David Mudrak made changes - 31/Aug/09 11:19 PM

Link

This issue will help resolve MDL-16438 [ MDL-16438 ]

David Mudrak committed 2 files to 'Moodle CVS' - 31/Aug/09 11:23 PM

~~MDL-20191~~ Subplugins are uninstalled together with the parent plugin

This is a first working implementation I have. I need to so I can
continue with the Workshop development. I think the performance can be
significantly improved here as the location of the subplugins is
evaluated atr least twice, I guess.

MODIFY	admin/modules.php		Rev. 1.70		(+2 -84 lines)
MODIFY	lib/adminlib.php		Rev. 1.388		(+144 -0 lines)

[ Permalink | « Hide ]

David Mudrak added a comment - 31/Aug/09 11:24 PM

Petr/Eloy, please review the commit. Thanks.

David Mudrak made changes - 31/Aug/09 11:24 PM

QA Assignee

skodak

[ Permalink | « Hide ]

David Mudrak added a comment - 31/Aug/09 11:26 PM

The working fix has been committed. The uninstall process displays the titles of subplugins being uninstalled, in the same way as the installation process does. See the commit message for a possible performance issue.

Try to uninstall a module using subplugins, like Database, to see the change in action.