Issue Details (XML | Word | Printable)

Key: MDL-20210
Type: Bug Bug
Status: Open Open
Priority: Major Major
Assignee: Petr Skoda
Reporter: Eloy Lafuente (stronk7)
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

DB auth plugin ends with own print_error() if no matching l/p (or l only for internal) is found

Created: 03/Sep/09 09:46 PM   Updated: 26/Oct/09 12:16 PM
Return to search
Component/s: Authentication
Affects Version/s: 1.7.7, 1.8.9, 1.9.5
Fix Version/s: 1.8.11, 1.9.7

Participants: Eloy Lafuente (stronk7), Iñaki Arenaza and Petr Skoda
Security Level: None
Affected Branches: MOODLE_17_STABLE, MOODLE_18_STABLE, MOODLE_19_STABLE
Fixed Branches: MOODLE_18_STABLE, MOODLE_19_STABLE


 Description  « Hide
Uhm...

was asking to Howard at: http://moodle.org/mod/forum/discuss.php?d=131784 and, when looking at the db/auth.php plugin... I've detected that it has one (two in fact) ANNOYING print_error() if the login/password check fails.

Other auth plugins haven't that at all. Expected behaviour is to return true/false only (without own printing and die) afaik. Can you imagine any reason for that? Seems that it's there since the beginning. :-(

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Petr Skoda made changes - 27/Sep/09 08:21 PM
Field Original Value New Value
Fix Version/s 1.7.7+ [ 10330 ]
Martin Dougiamas made changes - 21/Oct/09 04:17 PM
Fix Version/s 1.9.7 [ 10360 ]
Fix Version/s 1.9.6 [ 10340 ]
Martin Dougiamas made changes - 26/Oct/09 12:16 PM
Fix Version/s 1.8.11 [ 10383 ]
Fix Version/s 1.8.10 [ 10350 ]