Moodle

Should be looking at $PAGE->course when establishing settings for user context

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 2.0
  • Component/s: Libraries
  • Labels:
    None
  • Difficulty:
    Easy
  • Affected Branches:
    MOODLE_20_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

Currently load_for_user is looking for the course id as a parameter when loading setting for the user context.
Really it should first be looking to see if $PAGE->course has been set first, and then failing over to the HTTP params.

Activity

Hide
Sam Hemelryk added a comment -

Done and done, now looks for PAGE->course and if that is not set (possible if AJAX request) still looks for optional_param

Show
Sam Hemelryk added a comment - Done and done, now looks for PAGE->course and if that is not set (possible if AJAX request) still looks for optional_param

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: