Issue Details (XML | Word | Printable)

Key: MDL-20227
Type: Sub-task Sub-task
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Sam Hemelryk
Reporter: Sam Hemelryk
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-14632

Make the cache check course->modinfo is still valid before using it

Created: 07/Sep/09 04:16 PM   Updated: 09/Sep/09 09:45 AM
Return to search
Component/s: Lib
Affects Version/s: 2.0
Fix Version/s: 2.0

Participants: Sam Hemelryk
Security Level: None
Difficulty: Easy
Resolved date: 09/Sep/09
Affected Branches: MOODLE_20_STABLE
Fixed Branches: MOODLE_20_STABLE


 Description  « Hide
As Petr and David pointed out the navigation doesn't show newly created activities.
This is because the course modinfo is being cached...
As we agreed it would be a smart idea to compare modinfo to the current $COURSE to ensure
it is still valid and hasn't changed.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Sam Hemelryk committed 1 file to 'Moodle CVS' - 08/Sep/09 04:49 PM
navigation MDL-20227 Added compare function
This allows us to compare the modinfo stored in the cache with that against that active course
MODIFY lib/navigationlib.php   Rev. 1.12    (+24 -3 lines)
Sam Hemelryk committed 2 files to 'Moodle CVS' - 09/Sep/09 04:50 PM
navigation MDL-20227 Fixed simpletest regression
MODIFY lib/navigationlib.php   Rev. 1.16    (+3 -3 lines)
MODIFY lib/simpletest/testnavigationlib.php   Rev. 1.6    (+17 -2 lines)