Moodle

workshop 2.0: overall codebase architecture cleanup and fixing regression

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 2.0
  • Component/s: Workshop
  • Labels:
    None
  • Affected Branches:
    MOODLE_20_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

Due to the recent turning all workshop components into the proper subplugins, the whole architecture including DB table names and fileareas must be reviewed and regressions fixed. Together with this, the codebase architecture, names etc. will be unified
This includes:

  • /grading subplugins will be /form as they define the assessment form and how the peer grade is calculated based on the assessment form data
  • tables workshop_forms_{strategyname} are now workshopform_{strategyname} as workshopform_ is a separate workshop plugin
  • all subplugins will have their own filearea, therefore we can get rid of workshop_forms and return to the original specification. This also simplifies dimensionid (no master and local id as currently).
  • "nograding" strategy now called "comments"
  • "noerrors" strategy now called "numerrors"
  • consistently, any subplugin's logic class is in its lib.php

Issue Links

Activity

Hide
David Mudrak added a comment - - edited

fixes regressions of MDL-20192

Show
David Mudrak added a comment - - edited fixes regressions of MDL-20192
Hide
David Mudrak added a comment -

Committed. Also reverts the recent switch to using __get() because of the empty() issue.

Show
David Mudrak added a comment - Committed. Also reverts the recent switch to using __get() because of the empty() issue.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: